Bug 79694

Summary:

Make fast/selectors/040.html actually test background-color painting for ::selection when run in DRT

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Layout test	bdakin: review+, webkit.review.bot: commit-queue-

Daniel Bates

Reported 2012-02-27 12:13:34 PST

The test case fast/selectors/040.html, <http://trac.webkit.org/browser/trunk/LayoutTests/fast/selectors/040.html?rev=11995>, doesn't actually test ::selection handling when run in DRT. Although you can run this test by hand to verify that we honor the background-color property of the pseudo-element ::selection, it would be better to make this test capable of being run in DRT.

Attachments
Layout test (10.52 KB, patch) 2012-02-27 12:21 PST, Daniel Bates	bdakin: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2012-02-27 12:21:10 PST

Created attachment 129085 [details] Layout test I also converted the fast/selectors/040.html to be reftest and removed all the platform-specific render tree/pixel test results.

WebKit Review Bot

Comment 2 2012-02-27 16:21:41 PST

Comment on attachment 129085 [details] Layout test Attachment 129085 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11642266 New failing tests: fast/selectors/040.html

Daniel Bates

Comment 3 2016-12-06 09:59:10 PST

Committed r209404: <http://trac.webkit.org/changeset/209404>

Daniel Bates

Comment 4 2016-12-06 15:25:49 PST

Skipped the test on iOS Simulator as we do not seem to visually highlight a programmatic selection. Committed this in <http://trac.webkit.org/changeset/209428>

Note You need to log in before you can comment on or make changes to this bug.