Bug 79595

Summary: Setting style="" should destroy the element's inline style.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, ossy, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 79597    
Bug Blocks:    
Attachments:
Description Flags
Pschtat none

Andreas Kling
Reported 2012-02-25 20:58:17 PST
No need to hang an inline style object off of an element with an empty style attribute.
Attachments
Pschtat (1.46 KB, patch)
2012-02-25 21:00 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-02-25 21:00:47 PST
Created attachment 128901 [details] Pschtat
Andreas Kling
Comment 2 2012-02-25 21:08:34 PST
Comment on attachment 128901 [details] Pschtat Clearing flags on attachment: 128901 Committed r108924: <http://trac.webkit.org/changeset/108924>
Andreas Kling
Comment 3 2012-02-25 21:08:42 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2012-02-25 22:23:31 PST
Reopen, because it broke 4 inspector tests: (at least on Chromium and Qt) http://build.webkit.org/results/Chromium%20Win%20Release%20%28Tests%29/r108924%20%2823955%29/results.html
Ahmad Saleem
Comment 5 2022-07-26 09:58:29 PDT
I think the code is changed significantly and I only see following reference: https://github.com/WebKit/WebKit/blob/aff87f6cbcf56b5fe448770a00f51814fa626b7c/Source/WebCore/dom/Element.cpp#L2164 https://github.com/WebKit/WebKit/blob/aff87f6cbcf56b5fe448770a00f51814fa626b7c/Source/WebCore/dom/Element.cpp#L1964 While searching for "classAttributeChanged". I think this can be closed now as "RESOLVED CONFIGURATION CHANGED", ignore my comment if I am wrong. There was also no test in the attached patch, which I can test. Thanks!
Ryosuke Niwa
Comment 6 2022-07-26 10:03:15 PDT
Indeed, this code has changed substantially. No need to keep this bug open at this point.
Radar WebKit Bug Importer
Comment 7 2022-07-26 10:04:18 PDT
<rdar://problem/97612300>
Note You need to log in before you can comment on or make changes to this bug.