Bug 79575

Summary:

Fix unused variable warnings in HarfBuzzShaperBase

Product:

WebKit

Reporter:

Adrienne Walker <enne>

Component:

New Bugs

Assignee:

Adrienne Walker <enne>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bashi, enne

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Use ASSERT_UNUSED	kling: review+

Adrienne Walker

Reported 2012-02-25 10:42:46 PST

Fix unused variable warnings in HarfBuzzShaperBase

Attachments
Patch (1.46 KB, patch) 2012-02-25 10:55 PST, Adrienne Walker	no flags	Details Formatted Diff Diff
Use ASSERT_UNUSED (1.52 KB, patch) 2012-02-25 11:07 PST, Adrienne Walker	kling: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adrienne Walker

Comment 1 2012-02-25 10:47:21 PST

This was failing on ChromiumOS builds: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28tegra2%29/builds/4524/steps/cbuildbot/logs/stdio --SNIP-- third_party/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: In function 'void WebCore::normalizeSpacesAndMirrorChars(const UChar*, UChar*, int, WebCore::HarfBuzzShaperBase::NormalizeMode)': chromeos-chrome-19.0.1053.0_alpha-r1: third_party/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:58:10: error: variable 'error' set but not used [-Werror=unused-but-set-variable] chromeos-chrome-19.0.1053.0_alpha-r1: cc1plus: all warnings being treated as errors --SNIP--

Adrienne Walker

Comment 2 2012-02-25 10:55:03 PST

Created attachment 128874 [details] Patch

Adrienne Walker

Comment 3 2012-02-25 11:07:44 PST

Created attachment 128875 [details] Use ASSERT_UNUSED

Adrienne Walker

Comment 4 2012-02-25 11:11:41 PST

Committed r108903: <http://trac.webkit.org/changeset/108903>

Note You need to log in before you can comment on or make changes to this bug.