Bug 79571 – StringLiteral and NumericLiteral are allowed as ObjectLiteral getter / setter name

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Yusuke Suzuki]

According to ECMA262 5.1 section 11.1.5 'Object Initialiser', getter and setter name is 'PropertyName'.

    PropertyAssignment :
        PropertyName : AssignmentExpression
        get PropertyName ( ) { FunctionBody } 
        set PropertyName ( PropertySetParameterList ) { FunctionBody }

And PropertyName contains StringLiteral and NumericLiteral.

    PropertyName :
        IdentifierName
        StringLiteral
        NumericLiteral

So StringLiteral and NumericLiteral are allowed as ObjectLiteral getter / setter name.

for example,
  var obj = {
      get 42() { return 42; },
      get 'string'() { return 'string'; }
  };
is valid syntax.

[Yusuke Suzuki]

Created attachment 128869 [details]
Patch

[WebKit Review Bot]

Comment on attachment 128869 [details]
Patch

Attachment 128869 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11626440

New failing tests:
fast/js/property-getters-and-setters.html

[Yusuke Suzuki]

Created attachment 128872 [details]
Patch

[Yusuke Suzuki]

Sorry, fixed variable names o9, o10 on LayoutTests property-getters-and-setters.

[WebKit Review Bot]

Comment on attachment 128872 [details]
Patch

Attachment 128872 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11633409

New failing tests:
fast/js/property-getters-and-setters.html
inspector/protocol/console-agent.html

[Gavin Barraclough]

Comment on attachment 128872 [details]
Patch

Nice fix!

[WebKit Review Bot]

Comment on attachment 128872 [details]
Patch

Rejecting attachment 128872 [details] from commit-queue.

New failing tests:
fast/js/property-getters-and-setters.html
compositing/reflections/nested-reflection-transformed.html
Full output: http://queues.webkit.org/results/11628599

[Yusuke Suzuki]

Oops! I overlooked that there is LayoutTests/platform/chromium/fast/js/property-getters-and-setters-expected.txt!
So I attached revised patch soon, sorry to trouble you.

[Yusuke Suzuki]

Created attachment 128913 [details]
Patch

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 128913 [details]:

inspector/protocol/console-agent.html bug 79563 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 128913 [details]
Patch

Clearing flags on attachment: 128913

Committed r108935: <http://trac.webkit.org/changeset/108935>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.