| Summary: | StringLiteral and NumericLiteral are allowed as ObjectLiteral getter / setter name | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | barraclough, dglazkov, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 128869 [details]
Patch
Comment on attachment 128869 [details] Patch Attachment 128869 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11626440 New failing tests: fast/js/property-getters-and-setters.html Created attachment 128872 [details]
Patch
Sorry, fixed variable names o9, o10 on LayoutTests property-getters-and-setters. Comment on attachment 128872 [details] Patch Attachment 128872 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11633409 New failing tests: fast/js/property-getters-and-setters.html inspector/protocol/console-agent.html Comment on attachment 128872 [details]
Patch
Nice fix!
Comment on attachment 128872 [details] Patch Rejecting attachment 128872 [details] from commit-queue. New failing tests: fast/js/property-getters-and-setters.html compositing/reflections/nested-reflection-transformed.html Full output: http://queues.webkit.org/results/11628599 Oops! I overlooked that there is LayoutTests/platform/chromium/fast/js/property-getters-and-setters-expected.txt! So I attached revised patch soon, sorry to trouble you. Created attachment 128913 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 128913 [details]: inspector/protocol/console-agent.html bug 79563 (authors: caseq@chromium.org, loislo@chromium.org, and pfeldman@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 128913 [details] Patch Clearing flags on attachment: 128913 Committed r108935: <http://trac.webkit.org/changeset/108935> All reviewed patches have been landed. Closing bug. |
According to ECMA262 5.1 section 11.1.5 'Object Initialiser', getter and setter name is 'PropertyName'. PropertyAssignment : PropertyName : AssignmentExpression get PropertyName ( ) { FunctionBody } set PropertyName ( PropertySetParameterList ) { FunctionBody } And PropertyName contains StringLiteral and NumericLiteral. PropertyName : IdentifierName StringLiteral NumericLiteral So StringLiteral and NumericLiteral are allowed as ObjectLiteral getter / setter name. for example, var obj = { get 42() { return 42; }, get 'string'() { return 'string'; } }; is valid syntax.