Bug 79551

Summary: <content> element should behave as HTMLUnknownElement outside of a shadow DOM subtree
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, shinyak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dglazkov.github.com/Web-Components-Polyfill/news.html
Bug Depends on:    
Bug Blocks: 76434    
Attachments:
Description Flags
Patch
none
Patch
none
Catching up ToT dglazkov: review+

Dimitri Glazkov (Google)
Reported 2012-02-24 19:04:01 PST
This is specified here: http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#lower-boundary-encapsulation The key is that if the element is inactive, it should act as any HTML element: be stylable and show its contents. A good example of why this is good is http://dglazkov.github.com/Web-Components-Polyfill/news.html, which is a component definition (used here: http://dglazkov.github.com/Web-Components-Polyfill/). I added a special debug.css, which helps understand the structure of the component. If <content> were visible, I could style it and put "CONTENTS GO HERE" label with a selector or something. That's instant debugging for a component developer :)
Attachments
Patch (14.97 KB, patch)
2012-02-27 19:28 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (14.96 KB, patch)
2012-02-27 23:55 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Catching up ToT (14.37 KB, patch)
2012-02-28 00:27 PST, Hajime Morrita 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-02-26 22:00:49 PST
Looks like this came from http://crbug.com/114667
Hajime Morrita
Comment 2 2012-02-27 19:28:55 PST
Created attachment 129169 [details] Patch
Hajime Morrita
Comment 3 2012-02-27 23:55:48 PST
Created attachment 129200 [details] Patch
Hajime Morrita
Comment 4 2012-02-28 00:27:50 PST
Created attachment 129207 [details] Catching up ToT
Dimitri Glazkov (Google)
Comment 5 2012-02-28 08:57:13 PST
Comment on attachment 129207 [details] Catching up ToT View in context: https://bugs.webkit.org/attachment.cgi?id=129207&action=review > Source/WebCore/dom/ShadowRoot.h:104 > +// Put this TreeScope method here to inline it. Is it really so hot that we need to do this? > Source/WebCore/dom/ShadowRoot.h:105 > + Probably don't need this extra blank linke.
Hajime Morrita
Comment 6 2012-02-28 16:36:08 PST
Comment on attachment 129207 [details] Catching up ToT View in context: https://bugs.webkit.org/attachment.cgi?id=129207&action=review Hi Dimitri, thanks for the review! I'll land this after fixing your point. >> Source/WebCore/dom/ShadowRoot.h:104 >> +// Put this TreeScope method here to inline it. > > Is it really so hot that we need to do this? Since this is in every attach path, I want to minimize the impact. >> Source/WebCore/dom/ShadowRoot.h:105 >> + > > Probably don't need this extra blank linke. Sure.
Hajime Morrita
Comment 7 2012-02-28 18:00:21 PST
Committed r109179: <http://trac.webkit.org/changeset/109179>
Note You need to log in before you can comment on or make changes to this bug.