Bug 79542

Summary:

Add separate watchlist for Source/Platform/chromium/public/

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

Tools / Tests

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, jamesr, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	none

Darin Fisher (:fishd, Google)

Reported 2012-02-24 15:58:12 PST

Add separate watchlist for Source/Platform/chromium/public/ Even better than http://trac.webkit.org/changeset/108838, I think it makes sense for Adam and James to share in the fun of reviewing changes to Source/Platform/chromium/public/ :-)

Attachments
v1 patch (2.60 KB, patch) 2012-02-24 15:58 PST, Darin Fisher (:fishd, Google)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2012-02-24 15:58:35 PST

Created attachment 128823 [details] v1 patch

James Robinson

Comment 2 2012-02-24 16:00:46 PST

Comment on attachment 128823 [details] v1 patch Works for me, hopefully Adam's happy with this too :)

WebKit Review Bot

Comment 3 2012-02-24 16:06:53 PST

Attachment 128823 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 4 2012-02-24 18:19:37 PST

Comment on attachment 128823 [details] v1 patch Clearing flags on attachment: 128823 Committed r108879: <http://trac.webkit.org/changeset/108879>

WebKit Review Bot

Comment 5 2012-02-24 18:19:42 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.