Bug 79541

Summary: Implement WebGL extension EXT_texture_filter_anisotropic
Product: WebKit Reporter: Ben Vanik <benvanik>
Component: WebGLAssignee: Ben Vanik <benvanik>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bjacob, gustavo, japhet, kbr, ojan, pnormand, rakuco, vestbo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Ben Vanik 2012-02-24 15:55:36 PST 
Implement WebGL extension EXT_texture_filter_anisotropic
Comment 1 Ben Vanik 2012-02-24 15:58:30 PST 
Created attachment 128822 [details]
Patch
Comment 2 Ben Vanik 2012-02-24 16:06:03 PST 
Need to fix up the Xcode project - new patch coming soon (have to get a WebKit build going on my Mac first...)
Comment 3 Philippe Normand 2012-02-24 16:08:55 PST 
Comment on attachment 128822 [details]
Patch

Attachment 128822 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11631159
Comment 4 Early Warning System Bot 2012-02-24 16:25:38 PST 
Comment on attachment 128822 [details]
Patch

Attachment 128822 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11628227
Comment 5 Ben Vanik 2012-02-24 19:45:14 PST 
Created attachment 128841 [details]
Patch
Comment 7 Ben Vanik 2012-02-28 16:14:16 PST 
Created attachment 129350 [details]
Patch
Comment 8 Kenneth Russell 2012-02-28 18:14:59 PST 
Comment on attachment 129350 [details]
Patch

Looks good.
Comment 9 WebKit Review Bot 2012-03-01 18:20:07 PST 
Comment on attachment 129350 [details]
Patch

Rejecting attachment 129350 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ion.h
patching file Source/WebCore/html/canvas/WebGLObject.cpp
patching file Source/WebCore/html/canvas/WebGLRenderingContext.cpp
patching file Source/WebCore/html/canvas/WebGLRenderingContext.h
patching file Source/WebCore/platform/graphics/Extensions3D.h
patching file Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ru..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11751680
Comment 10 Kenneth Russell 2012-03-01 18:32:24 PST 
Sorry, I guess I let this patch sit too long. Could you rebase to TOT and upload it again?
Comment 11 Ben Vanik 2012-03-05 11:17:18 PST 
Created attachment 130163 [details]
Patch
Comment 12 Kenneth Russell 2012-03-05 11:47:08 PST 
Comment on attachment 130163 [details]
Patch

Thanks -- let's try again.
Comment 13 WebKit Review Bot 2012-03-05 11:52:04 PST 
Comment on attachment 130163 [details]
Patch

Rejecting attachment 130163 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

kbr@google.com found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11808709
Comment 14 Ben Vanik 2012-03-05 11:55:40 PST 
Created attachment 130173 [details]
Patch
Comment 15 Kenneth Russell 2012-03-05 11:56:30 PST 
Comment on attachment 130173 [details]
Patch

Let's try again.
Comment 16 WebKit Review Bot 2012-03-05 13:52:24 PST 
Comment on attachment 130173 [details]
Patch

Clearing flags on attachment: 130173

Committed r109798: <http://trac.webkit.org/changeset/109798>
Comment 17 WebKit Review Bot 2012-03-05 13:52:31 PST 
All reviewed patches have been landed.  Closing bug.