Summary: | REGRESSION (r108730): Webkit nightlies fails to start due to WKPreferencesGetSuppressIncrementalRendering renaming | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | sharikov.suba | ||||
Component: | WebKit Misc. | Assignee: | Andy Estes <aestes> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Critical | CC: | aestes, ap, aroben, kennon | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac (Intel) | ||||||
OS: | OS X 10.7 | ||||||
Bug Depends on: | 82098 | ||||||
Bug Blocks: | 79433 | ||||||
Attachments: |
|
Description
sharikov.suba
2012-02-24 11:28:26 PST
I can confirm I'm seeing this same issue. Created attachment 128810 [details]
Patch
Committed r108851: <http://trac.webkit.org/changeset/108851> Comment on attachment 128810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128810&action=review > Source/WebKit2/UIProcess/API/C/WKPreferences.h:179 > +// Defaults to false > +// These functions are deprecated. See <rdar://problem/10929617> Remove WKPreferences[Get|Set]SuppressIncrementalRendering from WKPreferences.h. > +WK_EXPORT void WKPreferencesSetSuppressIncrementalRendering(WKPreferencesRef preferencesRef, bool enabled); > +WK_EXPORT bool WKPreferencesGetSuppressIncrementalRendering(WKPreferencesRef preferencesRef); There's no need to put these in the header. Doing so will just make it easier for people to call them accidentally. (In reply to comment #4) > (From update of attachment 128810 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128810&action=review > > > Source/WebKit2/UIProcess/API/C/WKPreferences.h:179 > > +// Defaults to false > > +// These functions are deprecated. See <rdar://problem/10929617> Remove WKPreferences[Get|Set]SuppressIncrementalRendering from WKPreferences.h. > > +WK_EXPORT void WKPreferencesSetSuppressIncrementalRendering(WKPreferencesRef preferencesRef, bool enabled); > > +WK_EXPORT bool WKPreferencesGetSuppressIncrementalRendering(WKPreferencesRef preferencesRef); > > There's no need to put these in the header. Doing so will just make it easier for people to call them accidentally. The WK_EXPORT macro is needed in order for these symbols to be visible to Safari. I hope the deprecation warning is sufficient to keep people from using these methods. Comment on attachment 128810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128810&action=review >>> Source/WebKit2/UIProcess/API/C/WKPreferences.h:179 >>> +WK_EXPORT bool WKPreferencesGetSuppressIncrementalRendering(WKPreferencesRef preferencesRef); >> >> There's no need to put these in the header. Doing so will just make it easier for people to call them accidentally. > > The WK_EXPORT macro is needed in order for these symbols to be visible to Safari. I hope the deprecation warning is sufficient to keep people from using these methods. WK_EXPORT can be used in the .cpp file, too. It was later discovered that WebKit nighties are broken anyway with this version of Safari (bug 79390), so perhaps it would be better to roll this out, and let it crash on launch. This was rolled out in http://trac.webkit.org/changeset/111927 |