Summary: | [Chromium] Enable Viewport define by default | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fady Samuel <fsamuel> | ||||||||||||
Component: | New Bugs | Assignee: | Fady Samuel <fsamuel> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | dglazkov, fishd, rjkroege, tdanderson, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Fady Samuel
2012-02-24 11:20:44 PST
Created attachment 128773 [details]
Patch
Decided to only enable for Chromium. This still needs to be done, but we need to make sure we only enable it on chromium. Comment on attachment 128773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128773&action=review I think you could edit Source/WebKit/chromium/features.gypi to accomplish the same objective? (see the patch) > Source/JavaScriptCore/wtf/Platform.h:872 > +#define ENABLE_VIEWPORT 1 I think it's preferable to do this a different way. Created attachment 129109 [details]
[not for review] alternate implementation?
(In reply to comment #5) > Created an attachment (id=129109) [details] > [not for review] alternate implementation? Looks like this does the trick. Reuploading. Created attachment 129310 [details]
Patch
Comment on attachment 129310 [details] Patch Attachment 129310 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11710074 New failing tests: platform/chromium/fast/repaint/fixed-layout-360x240.html inspector/styles/override-screen-size.html Created attachment 133073 [details]
Patch for landing
(In reply to comment #8) > (From update of attachment 129310 [details]) > Attachment 129310 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11710074 > > New failing tests: > platform/chromium/fast/repaint/fixed-layout-360x240.html > inspector/styles/override-screen-size.html The fixed-layout-360x240 test is obsolete due to a redesign in the way things are done. Deleting it. Comment on attachment 133073 [details] Patch for landing Attachment 133073 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12090536 New failing tests: inspector/styles/override-screen-size.html Comment on attachment 133073 [details] Patch for landing Attachment 133073 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12071606 New failing tests: inspector/styles/override-screen-size.html (In reply to comment #12) > (From update of attachment 133073 [details]) > Attachment 133073 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/12071606 > > New failing tests: > inspector/styles/override-screen-size.html Argh, fixed layout and viewport are tightly coupled on Chromium, which turns out to make things a lot more complicated from a testing standpoint. We're looking into introducing a new flag to make the two operations independently testable. Created attachment 134307 [details]
Patch for landing
Attachment 134307 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
ERROR: File does not exist: 'LayoutTests/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png'
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 129310 [details] Patch Clearing flags on attachment: 129310 Committed r112411: <http://trac.webkit.org/changeset/112411> All reviewed patches have been landed. Closing bug. |