Bug 79437

Summary: Move FileSystem-related APIs from DOMWindow.idl to DOMWindowFileSystem.idl
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore Misc.Assignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, commit-queue, ericu, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79327    
Attachments:
Description Flags
Patch abarth: review-

Description Kentaro Hara 2012-02-23 21:18:56 PST 
For WebKit modularization, we can move FileSystem-related APIs from DOMWindow.idl to DOMWindowFileSystem.idl.
Comment 1 Kentaro Hara 2012-02-23 21:22:47 PST 
Created attachment 128645 [details]
Patch
Comment 2 Adam Barth 2012-02-23 23:34:13 PST 
Comment on attachment 128645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128645&action=review

> Source/WebCore/fileapi/DOMWindowFileSystem.idl:35
> +        attribute FileConstructor File;
> +        attribute FileListConstructor FileList;
> +        attribute BlobConstructor Blob;
> +        attribute [Conditional=BLOB] FileErrorConstructor FileError;
> +        attribute [Conditional=BLOB] FileReaderConstructor FileReader;
> +        attribute [Conditional=BLOB] WebKitBlobBuilderConstructor WebKitBlobBuilder;
> +        attribute [Conditional=BLOB] DOMURLConstructor webkitURL;

I'm not sure this is quite right.  I'm slightly unclear which of these APIs are part of FileSystem versus Blob or FileReader / FileWriter:

http://dev.w3.org/2006/webapi/FileAPI/
http://www.w3.org/TR/file-system-api/

We might need to ask EricU for some guidance.
Comment 3 Eric U. 2012-02-27 09:42:24 PST 
> > +        attribute FileConstructor File;
> > +        attribute FileListConstructor FileList;
> > +        attribute BlobConstructor Blob;
> > +        attribute [Conditional=BLOB] FileErrorConstructor FileError;
> > +        attribute [Conditional=BLOB] FileReaderConstructor FileReader;
> > +        attribute [Conditional=BLOB] WebKitBlobBuilderConstructor WebKitBlobBuilder;
> > +        attribute [Conditional=BLOB] DOMURLConstructor webkitURL;
> 
> I'm not sure this is quite right.  I'm slightly unclear which of these APIs are part of FileSystem versus Blob or FileReader / FileWriter:
> 
> http://dev.w3.org/2006/webapi/FileAPI/
> http://www.w3.org/TR/file-system-api/
> 
> We might need to ask EricU for some guidance.

None of those are from FileSystem.  BlobBuilder is from FileWriter [http://www.w3.org/TR/file-writer-api/], and the rest are from the File API.  They can all be moved out of DOMWIndow, but shouldn't go into anything with the name FileSystem on it.

As for BlobBuilder, I'm not sure; it's going to go away at some point soon anyway, as it's to be replaced by a constructable Blob.  So it can go wherever's convenient, and don't stress about it too much.
Comment 4 Adam Barth 2012-02-27 11:12:41 PST 
Comment on attachment 128645 [details]
Patch

The file-related APIs are spread out over a couple of different specs.  We should figure out which APIs go with which specs and see if the code can be organized along those lines too.
Comment 5 Adam Barth 2012-03-23 17:29:36 PDT 
Mark took care of these, I believe.