Bug 7943

Summary:

Layer outline does not repaint

Product:

WebKit

Reporter:

mitz

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

VERIFIED FIXED

Severity:

Normal

CC:

hyatt

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Test case	none
Patch	none
Patch including test and change log	none
Updated patch	darin: review+

mitz

Reported 2006-03-23 13:29:46 PST

Layers do not repaint their outline when invalidated. To reproduce: open the attached test case, resize the window so that you can scroll the square completely out of view. Scroll it out, then *slowly* scroll it in (you can Option-drag a scroll bar to scroll at mouse speed). Note how the leading edge of the green outline does not paint as it enters the view. I noticed two problems in RenderLayer::paintLayer() -- the rect in the PaintInfo passed for the outline phase is the clipRectToApply, which does not include the outline; and the outlineRect calculated by calculateRects doesn't seem to be of any help with painting the outline either.

Attachments
Test case (202 bytes, text/html) 2006-03-23 13:30 PST, mitz	no flags	Details
Patch (2.16 KB, patch) 2006-03-24 14:31 PST, mitz	no flags	Details Formatted Diff Diff
Patch including test and change log (13.52 KB, patch) 2006-03-27 12:28 PST, mitz	no flags	Details Formatted Diff Diff
Updated patch (13.19 KB, patch) 2006-04-02 13:20 PDT, mitz	darin: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2006-03-23 13:30:33 PST

Created attachment 7259 [details] Test case

mitz

Comment 2 2006-03-24 14:31:19 PST

Created attachment 7288 [details] Patch I'm holding off on making a test (and asking for a review) since I think I will be able to make an automated one once DumpRenderTree supports repaint tests.

mitz

Comment 3 2006-03-27 12:28:19 PST

Created attachment 7340 [details] Patch including test and change log

Darin Adler

Comment 4 2006-03-29 03:36:06 PST

Comment on attachment 7340 [details] Patch including test and change log I don't understand the value of changing m_object to renderer() on one line amidst many other uses of m_object. Change looks fine, r=me.

mitz

Comment 5 2006-04-02 12:25:25 PDT

Comment on attachment 7340 [details] Patch including test and change log Adele tried to land the patch but it doesn't merge with TOT. I'll try to post an updated version for review.

mitz

Comment 6 2006-04-02 13:20:33 PDT

Created attachment 7466 [details] Updated patch Updated to merge with TOT

Darin Adler

Comment 7 2006-04-02 16:17:12 PDT

Comment on attachment 7466 [details] Updated patch r=me

Note You need to log in before you can comment on or make changes to this bug.