Layer outline does not repaint

• Component: Layout and Rendering
• Status: VERIFIED FIXED

Layers do not repaint their outline when invalidated.

To reproduce: open the attached test case, resize the window so that you can scroll the square completely out of view. Scroll it out, then *slowly* scroll it in (you can Option-drag a scroll bar to scroll at mouse speed). Note how the leading edge of the green outline does not paint as it enters the view.

I noticed two problems in RenderLayer::paintLayer() -- the rect in the PaintInfo passed for the outline phase is the clipRectToApply, which does not include the outline; and the outlineRect calculated by calculateRects doesn't seem to be of any help with painting the outline either.

Created attachment 7259 [details]
Test case

Created attachment 7288 [details]
Patch

I'm holding off on making a test (and asking for a review) since I think I will be able to make an automated one once DumpRenderTree supports repaint tests.

Created attachment 7340 [details]
Patch including test and change log

[Darin Adler]

Comment on attachment 7340 [details]
Patch including test and change log

I don't understand the value of changing m_object to renderer() on one line amidst many other uses of m_object.

Change looks fine, r=me.

Comment on attachment 7340 [details]
Patch including test and change log

Adele tried to land the patch but it doesn't merge with TOT. I'll try to post an updated version for review.

Created attachment 7466 [details]
Updated patch

Updated to merge with TOT

[Darin Adler]

Comment on attachment 7466 [details]
Updated patch

r=me