Bug 79427

Summary: Move ChromeClient::showContextMenu() to ContextMenuClient
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: PlatformAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79054    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Hajime Morrita 2012-02-23 18:10:18 PST 
Looks like a historical artifact.
Comment 1 Hajime Morrita 2012-02-23 18:19:01 PST 
Created attachment 128626 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-23 18:21:00 PST 
Comment on attachment 128626 [details]
Patch

Really?  Mac doesn't ever call this?
Comment 3 Hajime Morrita 2012-02-23 18:26:39 PST 
Comment on attachment 128626 [details]
Patch

Oops. I found there was only one place in accessibility... that's why chromium can build without this.
Comment 4 Hajime Morrita 2012-02-23 22:50:36 PST 
Created attachment 128655 [details]
Patch
Comment 5 Hajime Morrita 2012-02-24 01:59:39 PST 
Created attachment 128691 [details]
Patch
Comment 6 Hajime Morrita 2012-02-26 18:13:12 PST 
Created attachment 128936 [details]
Patch
Comment 7 Adam Barth 2012-02-26 20:14:03 PST 
Comment on attachment 128936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128936&action=review

> Source/WebCore/ChangeLog:10
> +        This change localizes context menu relted code and will make it easy to

typo: relted
Comment 8 Hajime Morrita 2012-02-26 20:50:47 PST 
Created attachment 128946 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-02-26 22:25:46 PST 
The commit-queue encountered the following flaky tests while processing attachment 128946 [details]:

inspector/protocol/console-agent.html bug 79563 (authors: caseq@chromium.org, loislo@chromium.org, and pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Review Bot 2012-02-26 22:31:16 PST 
Comment on attachment 128946 [details]
Patch for landing

Clearing flags on attachment: 128946

Committed r108957: <http://trac.webkit.org/changeset/108957>
Comment 11 WebKit Review Bot 2012-02-26 22:31:22 PST 
All reviewed patches have been landed.  Closing bug.