Bug 79391

Summary:

[BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.

Product:

WebKit

Reporter:

Mike Fenton <mifenton>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	tonikitoo: review+, webkit.review.bot: commit-queue-
Rebased patch	none

Mike Fenton

Reported 2012-02-23 12:49:44 PST

Reduce the usage of BlackBerry::Platform namespace usage in SelectionHandler.cpp

Attachments
Patch (41.69 KB, patch) 2012-02-23 13:29 PST, Mike Fenton	tonikitoo: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Rebased patch (41.65 KB, patch) 2012-02-24 06:46 PST, Mike Fenton	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mike Fenton

Comment 1 2012-02-23 13:29:07 PST

Created attachment 128543 [details] Patch

Antonio Gomes

Comment 2 2012-02-23 13:47:42 PST

Comment on attachment 128543 [details] Patch 79392 has to go in first.

Antonio Gomes

Comment 3 2012-02-23 13:48:00 PST

(In reply to comment #2) > (From update of attachment 128543 [details]) > 79392 has to go in first. we cq+ it once it goes it.

WebKit Review Bot

Comment 4 2012-02-23 20:35:49 PST

Comment on attachment 128543 [details] Patch Rejecting attachment 128543 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: . Hunk #41 succeeded at 855 (offset 2 lines). Hunk #42 succeeded at 871 (offset 2 lines). Hunk #43 succeeded at 896 (offset 1 line). Hunk #44 succeeded at 913 (offset 1 line). Hunk #45 succeeded at 935 (offset 1 line). 2 out of 45 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11603673

WebKit Review Bot

Comment 5 2012-02-23 22:22:35 PST

Comment on attachment 128543 [details] Patch Rejecting attachment 128543 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: unk #41 succeeded at 855 (offset 2 lines). Hunk #42 succeeded at 871 (offset 2 lines). Hunk #43 succeeded at 897 (offset 2 lines). Hunk #44 succeeded at 914 (offset 2 lines). Hunk #45 succeeded at 936 (offset 2 lines). 2 out of 45 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11608709

WebKit Review Bot

Comment 6 2012-02-24 06:10:12 PST

Comment on attachment 128543 [details] Patch Rejecting attachment 128543 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: unk #41 succeeded at 855 (offset 2 lines). Hunk #42 succeeded at 871 (offset 2 lines). Hunk #43 succeeded at 897 (offset 2 lines). Hunk #44 succeeded at 914 (offset 2 lines). Hunk #45 succeeded at 936 (offset 2 lines). 2 out of 45 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11627005

Mike Fenton

Comment 7 2012-02-24 06:46:58 PST

Created attachment 128726 [details] Rebased patch

WebKit Review Bot

Comment 8 2012-02-24 07:34:29 PST

Comment on attachment 128726 [details] Rebased patch Clearing flags on attachment: 128726 Committed r108796: <http://trac.webkit.org/changeset/108796>

WebKit Review Bot

Comment 9 2012-02-24 07:34:39 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.