| Summary: | [BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Fenton <mifenton> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | tonikitoo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mike Fenton
2012-02-23 12:49:44 PST
Created attachment 128543 [details]
Patch
Comment on attachment 128543 [details]
Patch
79392 has to go in first.
(In reply to comment #2) > (From update of attachment 128543 [details]) > 79392 has to go in first. we cq+ it once it goes it. Comment on attachment 128543 [details] Patch Rejecting attachment 128543 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: . Hunk #41 succeeded at 855 (offset 2 lines). Hunk #42 succeeded at 871 (offset 2 lines). Hunk #43 succeeded at 896 (offset 1 line). Hunk #44 succeeded at 913 (offset 1 line). Hunk #45 succeeded at 935 (offset 1 line). 2 out of 45 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11603673 Comment on attachment 128543 [details] Patch Rejecting attachment 128543 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: unk #41 succeeded at 855 (offset 2 lines). Hunk #42 succeeded at 871 (offset 2 lines). Hunk #43 succeeded at 897 (offset 2 lines). Hunk #44 succeeded at 914 (offset 2 lines). Hunk #45 succeeded at 936 (offset 2 lines). 2 out of 45 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11608709 Comment on attachment 128543 [details] Patch Rejecting attachment 128543 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: unk #41 succeeded at 855 (offset 2 lines). Hunk #42 succeeded at 871 (offset 2 lines). Hunk #43 succeeded at 897 (offset 2 lines). Hunk #44 succeeded at 914 (offset 2 lines). Hunk #45 succeeded at 936 (offset 2 lines). 2 out of 45 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11627005 Created attachment 128726 [details]
Rebased patch
Comment on attachment 128726 [details] Rebased patch Clearing flags on attachment: 128726 Committed r108796: <http://trac.webkit.org/changeset/108796> All reviewed patches have been landed. Closing bug. |