Bug 79385 – REGRESSION (r99369): File input button doesn't highlight when pressed

• Component: Forms
• Status: RESOLVED FIXED

[Daniel Bates]

Clicking and holding on the file input button doesn't visually highlight the button.

[Daniel Bates]

Created attachment 128523 [details]
Patch and layout test

[WebKit Review Bot]

Comment on attachment 128523 [details]
Patch and layout test

Attachment 128523 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11574412

New failing tests:
fast/forms/file/file-input-pressed-state.html

[Alexey Proskuryakov]

<rdar://problem/10907808>

[Daniel Bates]

Created attachment 131195 [details]
Patch and layout tests

Renamed m_lastCanReceiveDroppedFilesState to m_canReceiveDroppedFiles and modified the RenderFileUploadControl constructor to initialize this instance variable with the value of HTMLInputElement::canReceiveDroppedFiles().

On another note, the name "canReceiveDroppedFiles" doesn't sufficiently describe its purpose. HTMLInputElement::canReceiveDroppedFiles() returns true when a person is hovering a dragged file(s) over an <input type="file"> and false otherwise. I can't think of a good name at the moment. Maybe a name that incorporates words/phrases such as "hovering", or "drag entered"?

For completeness, the layout test is a pixel test and passes using an Apple Mac WebKit build on my MacBook Pro running 10.7.3. I'll rebaseline the results for the non-Apple Mac ports upon landing this patch.

[WebKit Review Bot]

Comment on attachment 131195 [details]
Patch and layout tests

Attachment 131195 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11937257

New failing tests:
fast/forms/file/file-input-pressed-state.html

[Kent Tamura]

Comment on attachment 131195 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=131195&action=review

> LayoutTests/fast/forms/file/file-input-pressed-state.html:7
> +<script>
> +if (window.layoutTestController)
> +  layoutTestController.dumpAsText(true); // Dump pixel test result.
> +</script>

Inconsistent indentation.  Another <script> block uses 4-space indentation.

We had better add a comment that we are not interested in a render tree dump in this test.

[Daniel Bates]

(In reply to comment #6)
> > LayoutTests/fast/forms/file/file-input-pressed-state.html:7
> > +<script>
> > +if (window.layoutTestController)
> > +  layoutTestController.dumpAsText(true); // Dump pixel test result.
> > +</script>
> 
> Inconsistent indentation.  Another <script> block uses 4-space indentation.

Will fix.

> 
> We had better add a comment that we are not interested in a render tree dump in this test.

Will add HTML comments of the form:

<!-- The output of this test is only meaningful as a pixel test result because form controls have a platform-specific look-and-feel. -->
<!-- You can run this test either in DRT as a pixel test or by hand. -->

[Daniel Bates]

Committed r110598: <http://trac.webkit.org/changeset/110598>