Summary: | Shave .2% on PLT by removing bogus strcmp. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | SVG | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, ggaren | ||||
Priority: | P4 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2006-03-23 11:45:37 PST
Created attachment 7255 [details]
Remove bogus strcmp to save on plt
Can't "!" also be present for comment elements? Comment on attachment 7255 [details]
Remove bogus strcmp to save on plt
I think the right change is to change the && to a ||. We're supposed to allow tags like <!custom> I believe.
I had considered the ||, but hyatt and I couldn't think of any valid use case for !tagname. I'll change it to or and add a test case for parsing a <!foo></!foo> tag. (In reply to comment #4) > I had considered the ||, but hyatt and I couldn't think of any valid use case > for !tagname. I'll change it to or and add a test case for parsing a > <!foo></!foo> tag. If we're going to disallow anything starting with "!" (and Dave is definitely an authority on making that call), we should both have tests and also change the comment. I think we can do better than a comment that specifically mentions DOCTYPE and code that checks only for "!". |