Bug 79343

Summary: Move MediaStream related declarations from DOMWindow to DOMWindowMediaStream
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79327, 78440    
Attachments:
Description Flags
Patch eric: review+, webkit.review.bot: commit-queue-

Adam Barth
Reported 2012-02-23 01:06:11 PST
Move MediaStream related declarations from DOMWindow to DOMWindowMediaStream
Attachments
Patch (4.56 KB, patch)
2012-02-23 01:07 PST, Adam Barth 		eric: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-02-23 01:07:04 PST
Created attachment 128426 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-23 01:07:37 PST
Comment on attachment 128426 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-02-23 04:06:13 PST
Comment on attachment 128426 [details] Patch Rejecting attachment 128426 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ebKit/chromium/third_party/yasm/source/patched-yasm --revision 73761 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 73761. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11608201
WebKit Review Bot
Comment 4 2012-02-23 14:54:45 PST
Comment on attachment 128426 [details] Patch Rejecting attachment 128426 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 990. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/WebCore.gypi.rej patching file Source/WebCore/mediastream/DOMWindowMediaStream.idl patching file Source/WebCore/page/DOMWindow.idl Hunk #1 FAILED at 317. Hunk #2 FAILED at 527. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/page/DOMWindow.idl.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11599431
Note You need to log in before you can comment on or make changes to this bug.