| Summary: | Web Inspector: add experiment that loads stylesheets as links | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, me, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Feldman
2012-02-23 00:34:25 PST
Created attachment 128423 [details]
Patch
"persistence extensions"? (In reply to comment #2) > "persistence extensions"? This minor change is for us to be able to persist changes to inspector styles while developing inspector. Today, inspector loads stylesheets using synchronous XHRs and inject them into the document. As a result, when we debug inspector, navigation to the original resources does not work, Save As does not work, extensions that can save modified resources do not work. This change basically introduces debugging version of the front-end that uses conservative <link> tags for styles, hence making all the machinery above functioning. The commit-queue encountered the following flaky tests while processing attachment 128423 [details]: perf/object-keys.html bug 63769 (author: ojan@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 128423 [details] Patch Clearing flags on attachment: 128423 Committed r108634: <http://trac.webkit.org/changeset/108634> All reviewed patches have been landed. Closing bug. Why not just load all stylesheets via <link>? Why load them synchronously? (In reply to comment #7) > Why not just load all stylesheets via <link>? Why load them synchronously? We load them lazily in View.js. Otherwise it would flicker. |