Bug 79336

Summary: [Chromium] Add HarfBuzzShaperBase class
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: TextAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: efidler, evan, jdaggett, tonikitoo, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 69826    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Kenichi Ishibashi 2012-02-22 23:36:40 PST 
I'd like add a base class of HarfBuzz text shaper to share the code between old HarfBuzz and HarfBuzz-ng, to address Evan's comment on https://bugs.webkit.org/show_bug.cgi?id=69826#c18.
Comment 1 Kenichi Ishibashi 2012-02-22 23:52:45 PST 
Created attachment 128414 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-02-22 23:53:51 PST 
Hi Evan,

Could you please review the patch?
Comment 3 Evan Martin 2012-02-23 07:52:39 PST 
Looks great, thanks for refactoring!
Comment 4 Tony Chang 2012-02-23 10:29:38 PST 
Comment on attachment 128414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128414&action=review

> Source/WebCore/WebCore.gypi:3472
> +            'platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp',
> +            'platform/graphics/harfbuzz/HarfBuzzShaperBase.h',

Can you also include the cpp file in PlatformBlackBerry.cmake?

> Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:303
> +        if (static_cast<unsigned>(logClustersIndex) < m_item.item.length && isWordEnd(m_item.item.pos + logClustersIndex))

Should logClustersIndex be unsigned or size_t?  That might remove some of the casts.
Comment 5 Kenichi Ishibashi 2012-02-23 16:01:26 PST 
Created attachment 128584 [details]
Patch for landing
Comment 6 Kenichi Ishibashi 2012-02-23 16:02:52 PST 
Comment on attachment 128414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128414&action=review

Thank you for review Evan and Tony!

>> Source/WebCore/WebCore.gypi:3472
>> +            'platform/graphics/harfbuzz/HarfBuzzShaperBase.h',
> 
> Can you also include the cpp file in PlatformBlackBerry.cmake?

Done.

>> Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:303
>> +        if (static_cast<unsigned>(logClustersIndex) < m_item.item.length && isWordEnd(m_item.item.pos + logClustersIndex))
> 
> Should logClustersIndex be unsigned or size_t?  That might remove some of the casts.

Done.
Comment 7 WebKit Review Bot 2012-02-23 22:59:46 PST 
Comment on attachment 128584 [details]
Patch for landing

Clearing flags on attachment: 128584

Committed r108733: <http://trac.webkit.org/changeset/108733>
Comment 8 WebKit Review Bot 2012-02-23 22:59:51 PST 
All reviewed patches have been landed.  Closing bug.