|Summary:||[Qt] Build fix. Qt WebKit2 can not be compiled due to QtWebPageEventHandler.|
|Product:||WebKit||Reporter:||Dongseong Hwang <dongseong.hwang>|
|Component:||WebKit Qt||Assignee:||Simon Hausmann <hausmann>|
|Severity:||Normal||CC:||abecsi, hausmann, jturcotte, kenneth, ossy|
|Version:||528+ (Nightly build)|
Description Dongseong Hwang 2012-02-22 23:34:56 PST
I can not build WebKit2 on qt5 because QtWebPageEventHandler calls m_webView->setInputMethodHints(Qt::InputMethodHints(editor.inputMethodHints));.
Comment 2 Simon Hausmann 2012-02-23 00:16:01 PST
Comment on attachment 128407 [details] patch Well, but this isn't quite correct either, we still _do_ need to propagate the input method hints to the input method. It's just that the mechanism has changed slightly. FWIW, the Qt 5 version that we're developing against currently still has this method (see webkit-qt mailing list of announcements of version changes). That said, QQuickItem::setInputMethodHints has always been a convenience function for not having to re-implement the inputMethodQuery. Since we do that anyway though, we can apply a fix that works with any Qt 5 version, by responding to the Qt::ImHints input method query and returning the hints from the editor state there.
Comment 3 Dongseong Hwang 2012-02-23 00:44:01 PST
Ok. I little know about Qt5, so I can not fix it. I want someone to fix it.
Comment 4 Dongseong Hwang 2012-02-23 00:44:13 PST
(In reply to comment #0) > I can not build WebKit2 on qt5 because QtWebPageEventHandler calls m_webView->setInputMethodHints(Qt::InputMethodHints(editor.inputMethodHints));. QQuickItem does not have a setInputMethodHints(Qt::InputMethodHints hints) method.
Comment 5 Simon Hausmann 2012-02-23 06:11:48 PST
*** Bug 79250 has been marked as a duplicate of this bug. ***
Comment 7 Simon Hausmann 2012-02-23 06:18:03 PST
Created attachment 128474 [details] Patch Patch that actually compiles :)
Comment 8 Csaba Osztrogonác OOO_until_5th_Sep 2012-02-23 10:35:22 PST
Comment on attachment 128474 [details] Patch Clearing flags on attachment: 128474 Committed r108639: <http://trac.webkit.org/changeset/108639>
Comment 9 Csaba Osztrogonác OOO_until_5th_Sep 2012-02-23 10:35:31 PST
All reviewed patches have been landed. Closing bug.