|Summary:||[Qt] Build fix. Qt WebKit2 can not be compiled due to QtWebPageEventHandler.|
|Product:||WebKit||Reporter:||Dongseong Hwang <firstname.lastname@example.org>|
|Component:||WebKit Qt||Assignee:||Simon Hausmann <email@example.com>|
|Severity:||Normal||CC:||firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org|
|Version:||528+ (Nightly build)|
I can not build WebKit2 on qt5 because QtWebPageEventHandler calls m_webView->setInputMethodHints(Qt::InputMethodHints(editor.inputMethodHints));.
(From update of attachment 128407 [details]) Well, but this isn't quite correct either, we still _do_ need to propagate the input method hints to the input method. It's just that the mechanism has changed slightly. FWIW, the Qt 5 version that we're developing against currently still has this method (see webkit-qt mailing list of announcements of version changes). That said, QQuickItem::setInputMethodHints has always been a convenience function for not having to re-implement the inputMethodQuery. Since we do that anyway though, we can apply a fix that works with any Qt 5 version, by responding to the Qt::ImHints input method query and returning the hints from the editor state there.
Ok. I little know about Qt5, so I can not fix it. I want someone to fix it.
(In reply to comment #0) > I can not build WebKit2 on qt5 because QtWebPageEventHandler calls m_webView->setInputMethodHints(Qt::InputMethodHints(editor.inputMethodHints));. QQuickItem does not have a setInputMethodHints(Qt::InputMethodHints hints) method.
*** Bug 79250 has been marked as a duplicate of this bug. ***
Created an attachment (id=128474) [details] Patch Patch that actually compiles :)
(From update of attachment 128474 [details]) Clearing flags on attachment: 128474 Committed r108639: <http://trac.webkit.org/changeset/108639>