Bug 79329

Summary: LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, webkit.review.bot, yosin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70298    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch
none
Patch 4 none

Description Kent Tamura 2012-02-22 22:11:31 PST 
We need to update the test.

http://trac.webkit.org/changeset/108228/
Comment 2 yosin 2012-02-26 20:28:54 PST 
Created attachment 128944 [details]
Patch 1
Comment 3 Kent Tamura 2012-02-26 20:30:49 PST 
Comment on attachment 128944 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=128944&action=review

> LayoutTests/platform/chromium/test_expectations.txt:2152
>  BUGCR54330 MAC : fast/forms/number/input-spinbutton-capturing.html = PASS TEXT
> -BUGCR54331 MAC : fast/forms/number/input-number-events.html = PASS TEXT
>  

You don't fix the flakiness which we had seen before r108228.  So you don't need to remove the line.

> LayoutTests/platform/chromium/test_expectations.txt:-3331
> -BUGWK70298 WIN LINUX : fast/forms/number/input-number-events.html = TEXT PASS

ditto.
Comment 4 yosin 2012-02-26 20:40:43 PST 
Created attachment 128945 [details]
Patch 2
Comment 5 Kent Tamura 2012-02-26 20:48:40 PST 
Comment on attachment 128945 [details]
Patch 2

ok
Comment 6 WebKit Review Bot 2012-02-26 21:26:06 PST 
The commit-queue encountered the following flaky tests while processing attachment 128945 [details]:

inspector/protocol/console-agent.html bug 79563 (authors: caseq@chromium.org, loislo@chromium.org, and pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Review Bot 2012-02-26 21:27:57 PST 
Comment on attachment 128945 [details]
Patch 2

Clearing flags on attachment: 128945

Committed r108955: <http://trac.webkit.org/changeset/108955>
Comment 8 WebKit Review Bot 2012-02-26 21:28:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Hajime Morrita 2012-02-26 23:55:10 PST 
Reopening to attach new patch.
Comment 10 Hajime Morrita 2012-02-26 23:55:13 PST 
Created attachment 128970 [details]
Patch
Comment 11 Hajime Morrita 2012-02-26 23:57:31 PST 
Comment on attachment 128970 [details]
Patch

Ooops wrong url...
Comment 12 Kent Tamura 2012-02-27 22:10:12 PST 
Comment on attachment 128945 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=128945&action=review

> LayoutTests/fast/forms/number/input-number-events-expected.txt:11
> -PASS changeEventCounter is 0
> +PASS changeEventCounter is 1 

It seems the test is still failing because of a trailing space.
See the page linked in https://bugs.webkit.org/show_bug.cgi?id=79329#c1
Comment 13 yosin 2012-02-27 22:24:14 PST 
Reopening to attach new patch.
Comment 14 yosin 2012-02-27 22:24:17 PST 
Created attachment 129190 [details]
Patch 4
Comment 15 Kent Tamura 2012-02-27 22:25:03 PST 
Comment on attachment 129190 [details]
Patch 4

ok
Comment 16 WebKit Review Bot 2012-02-27 23:02:15 PST 
Comment on attachment 129190 [details]
Patch 4

Clearing flags on attachment: 129190

Committed r109082: <http://trac.webkit.org/changeset/109082>
Comment 17 WebKit Review Bot 2012-02-27 23:02:20 PST 
All reviewed patches have been landed.  Closing bug.