Bug 79321

Summary: [chromium] Clean up GraphicsContext3D initialization paths
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, gman, jamesr, kbr, nduca, piman, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
delta from last patch
none
Patch none

James Robinson
Reported 2012-02-22 20:22:15 PST
[chromium] Clean up GraphicsContext3D initialization paths
Attachments
Patch (29.58 KB, patch)
2012-02-22 20:30 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
delta from last patch (4.07 KB, patch)
2012-02-23 15:31 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (31.82 KB, patch)
2012-02-23 15:39 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-02-22 20:30:01 PST
Created attachment 128378 [details] Patch
Kenneth Russell
Comment 2 2012-02-23 13:03:54 PST
Comment on attachment 128378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128378&action=review Looks good. r=me > Source/WebKit/chromium/ChangeLog:21 > + 2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a Missing end of comment? > Source/WebKit/chromium/src/GraphicsContext3DPrivate.h:58 > + // via ContextLost before using the context in any way.. Once made current on a thread, the context cannot Two periods after "way".
James Robinson
Comment 3 2012-02-23 13:08:57 PST
Committed r108666: <http://trac.webkit.org/changeset/108666>
Adrienne Walker
Comment 4 2012-02-23 15:11:56 PST
Committed r108679: <http://trac.webkit.org/changeset/108679>
Adrienne Walker
Comment 5 2012-02-23 15:12:46 PST
Breaks tests. See commit above.
James Robinson
Comment 6 2012-02-23 15:30:43 PST
This broke some plugin tests because I wasn't properly retaining the temporary graphics context across WebViewImpl::graphicsContext3D() calls before the compositor was fully initialized. I've made an attempt at making this a bit clearer, because it sure confused the heck out of me.
James Robinson
Comment 7 2012-02-23 15:31:33 PST
Created attachment 128568 [details] delta from last patch
James Robinson
Comment 8 2012-02-23 15:39:39 PST
Created attachment 128571 [details] Patch
James Robinson
Comment 9 2012-02-23 15:40:21 PST
Ken - would you mind taking another look? The differences here are in WebViewImpl::graphicsContext3D() and WebViewImpl::createLayerTreeHost3D(). I've added some inline comments to try to explain what the code is trying to do a bit more explicitly.
Kenneth Russell
Comment 10 2012-02-23 17:29:16 PST
Comment on attachment 128571 [details] Patch The delta looks fine to me.
James Robinson
Comment 11 2012-02-23 17:38:19 PST
Comment on attachment 128571 [details] Patch Clearing flags on attachment: 128571 Committed r108706: <http://trac.webkit.org/changeset/108706>
James Robinson
Comment 12 2012-02-23 17:38:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.