Bug 79304 – Make parsing color presentation attributes do less pointless work.

• Component: DOM
• Status: RESOLVED FIXED

[Andreas Kling]

HTMLElement::addHTMLColorToStyle() already knows how to extract a color from the string it receives. We should create the CSSValue there instead of simply validating the string before sending it through CSSParser.

[Andreas Kling]

Created attachment 128337 [details]
Le Patch

[Antti Koivisto]

Comment on attachment 128337 [details]
Le Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128337&action=review

> Source/WebCore/ChangeLog:10
> +
> +        Let HTMLElement::addHTMLColorToStyle() construct the color CSSValue directly
> +        rather than passing a string that has to go through CSSParser.
> +

A word about performance?

> Source/WebCore/css/StylePropertySet.h:74
> +    // These expand shorthand properties into multiple properties.
> +    bool setProperty(int propertyID, const String& value, bool important = false, CSSStyleSheet* contextStyleSheet = 0);
> +    void setProperty(int propertyID, PassRefPtr<CSSValue>, bool important = false);
> +
> +    // These do not. FIXME: This is too messy, we can do better.
>      bool setProperty(int propertyID, int value, bool important = false, CSSStyleSheet* contextStyleSheet = 0);
>      bool setProperty(int propertyID, double value, CSSPrimitiveValue::UnitTypes, bool important = false, CSSStyleSheet* contextStyleSheet = 0);
> -    bool setProperty(int propertyID, const String& value, bool important = false, CSSStyleSheet* contextStyleSheet = 0);
>      void setProperty(const CSSProperty&, CSSProperty* slot = 0);

This really needs cleaning up. Oh well, you have the FIXME.

[Andreas Kling]

Comment on attachment 128337 [details]
Le Patch

Clearing flags on attachment: 128337

Committed r108586: <http://trac.webkit.org/changeset/108586>

[Andreas Kling]

All reviewed patches have been landed.  Closing bug.