Bug 79294

Summary: [JSC] Implement ArrayBuffer and typed array cloning in JSC
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: WebCore JavaScriptAssignee: Dmitry Lomov <dslomov>
Status: RESOLVED FIXED    
Severity: Normal CC: dslomov, kbr, levin, oliver, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Implementation + tests none

Description Dmitry Lomov 2012-02-22 16:05:30 PST
Following http://www.khronos.org/registry/typedarray/specs/latest/#9.
Comment 1 Dmitry Lomov 2012-02-22 16:10:49 PST
Created attachment 128318 [details]
Implementation + tests
Comment 2 WebKit Review Bot 2012-02-22 18:51:11 PST
Comment on attachment 128318 [details]
Implementation + tests

Clearing flags on attachment: 128318

Committed r108594: <http://trac.webkit.org/changeset/108594>
Comment 3 WebKit Review Bot 2012-02-22 18:51:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Yong Li 2012-03-23 14:11:16 PDT
if (!arrayBufferObj || !arrayBufferObj->inherits(&JSArrayBuffer::s_info))
 1241 return false; 

It assumes arrayBufferObj must be a JSArrayBuffer, however arrays like JSUitn8Array are derived from JSArrayBufferView.

See https://bugs.webkit.org/show_bug.cgi?id=82090
Comment 5 Dmitry Lomov 2012-03-23 14:27:42 PDT
(In reply to comment #3)
> All reviewed patches have been landed.  Closing bug.

(In reply to comment #4)
> if (!arrayBufferObj || !arrayBufferObj->inherits(&JSArrayBuffer::s_info))
>  1241 return false; 
> 
> It assumes arrayBufferObj must be a JSArrayBuffer, however arrays like JSUitn8Array are derived from JSArrayBufferView.

That is true but array buffer views are handled separately. 
There are numerous tests that pass checking that it all works.
> 
> See https://bugs.webkit.org/show_bug.cgi?id=82090