Summary: | nativeKeyCode for WebKeyboardEvent not set on Windows | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | garykac | ||||||||
Component: | UI Events | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | fishd, garykac, japhet, pkasting, rniwa, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
Attachments: |
|
Description
garykac
2012-02-22 15:45:58 PST
Created attachment 128308 [details]
Patch
Comment on attachment 128308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128308&action=review > Source/WebKit/chromium/ChangeLog:7 > + Why are we making this change? r- due to the lack of explanation. Created attachment 129286 [details]
Patch
Comment on attachment 129286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129286&action=review > Source/WebKit/chromium/ChangeLog:3 > + Set the key event's nativeKeyCode on Windows Chromium so that it Nit: Tab! You also need to put this description below "Reviewed by" line. > Source/WebKit/chromium/ChangeLog:15 > + this change will bring Windows in line withe other platforms. Nit: typo withe. Comment on attachment 129286 [details]
Patch
r- due to tab characters in the change log.
Created attachment 129287 [details]
Patch
Comment on attachment 129287 [details]
Patch
You're not a committer yet, right? If you want me to land it via commit-queue or are you going to ask someone to land your patch?
Sending it to the commit-queue would be great. Thanks! (In reply to comment #8) > Sending it to the commit-queue would be great. Thanks! Then please set cq? flag. Comment on attachment 129287 [details]
Patch
cq? set
Comment on attachment 129287 [details] Patch Clearing flags on attachment: 129287 Committed r109128: <http://trac.webkit.org/changeset/109128> All reviewed patches have been landed. Closing bug. |