Summary: | [Windows, WinCairo] Handle indeterminate state for checkbox in Windows Theme | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lynn Neir <lynn.neir> | ||||
Component: | Layout and Rendering | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, bfulgham, lynn.neir, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Lynn Neir
2012-02-22 15:45:50 PST
Created attachment 128600 [details]
Correct handling of CheckBox when in indeterminate state
Thanks for the update, Lynn. I've generated a patch based on your suggested change.
Comment on attachment 128600 [details] Correct handling of CheckBox when in indeterminate state View in context: https://bugs.webkit.org/attachment.cgi?id=128600&action=review > Source/WebCore/ChangeLog:8 > + Tested by fast/forms/indeterminate.html I wish we our regression tests actually tested RenderThemeWin! Then we could check in new pixel results for this test. Comment on attachment 128600 [details] Correct handling of CheckBox when in indeterminate state Clearing flags on attachment: 128600 Committed r108791: <http://trac.webkit.org/changeset/108791> All reviewed patches have been landed. Closing bug. |