Summary: | Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2012-02-22 14:39:36 PST
Created attachment 128315 [details]
Patch v1
Comment on attachment 128315 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=128315&action=review > Source/WebKit2/UIProcess/WebLoaderClient.cpp:245 > + if (m_client.version > 0 || !m_client.shouldGoToBackForwardListItem) > return true; You should add a comment here explaining the version check. > Source/WebKit2/WebProcess/WebPage/WebPage.h:506 > + bool willGoToBackForwardItemCallbackEnabled() { return m_willGoToBackForwardItemCallbackEnabled; } This can be const. |