Bug 79227

Summary: build-webkit should use environment variable at number of CPU detection on all platform
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, mrobinson, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch none

Gabor Rapcsanyi
Reported 2012-02-22 05:25:49 PST
It would be good (mostly for buildbots) if we could set an environment variable to set the number of cpus which the build script will use. For example if we have a server with 24 cores and we have some low priority bots it would be easy just set an environment variable for them.
Attachments
proposed patch (1.92 KB, patch)
2012-02-22 05:50 PST, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2012-02-22 05:35:54 PST
On Qt and Gtk platforms the MAKEFLAGS environment variable is enough for this purpose but Chromium just use --makeargs or determineNumberOfCPUs for fallback. The --makeargs option is good when you compile by hand but not for buildbots.
Gabor Rapcsanyi
Comment 2 2012-02-22 05:50:27 PST
Created attachment 128187 [details] proposed patch
WebKit Review Bot
Comment 3 2012-02-22 10:10:27 PST
Comment on attachment 128187 [details] proposed patch Clearing flags on attachment: 128187 Committed r108513: <http://trac.webkit.org/changeset/108513>
WebKit Review Bot
Comment 4 2012-02-22 10:10:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.