Bug 79170

Summary:

Should be able to reconfigure a non-configurable property as read-only

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	sam: review+

Description Gavin Barraclough 2012-02-21 17:36:20 PST

See ES5.1 8.12.9 10.a.i - the spec prohibits making a read-only property writable, but does not inhibit making a writable property read-only.

Comment 1 Gavin Barraclough 2012-02-21 17:39:35 PST

Created attachment 128095 [details]
Fix

Comment 2 Sam Weinig 2012-02-21 17:42:27 PST

Comment on attachment 128095 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=128095&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Should be able to reconfigure a non-configurable property as writable

This title contradicts the description below.

> Source/JavaScriptCore/runtime/JSGlobalData.h:252
> -
> +        

Why?

> Source/JavaScriptCore/runtime/JSGlobalData.h:370
> +        bool m_inDefineOwnProperty;
> +
> +

This whitespace is not all needed.

Comment 3 Gavin Barraclough 2012-02-21 17:51:18 PST

Fixed in r108427