Bug 79130

Summary: Web Inspector: replace RawSourceCode with a set of global mappings.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Path. none

Pavel Podivilov
Reported 2012-02-21 11:06:39 PST
Single source file could be referenced from a bunch of compiler source mappings that came from scripts with different urls (see bug 79122). RawSourceCode doesn't support this scenario. We need a more generic interface that maps VM scripts to UISourceCodes and back, e.g.: SourceMapping { uiLocation rawLocationToUILocation(scriptId, lineNumber, columnNumber) rawLocation uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber) Array<UISourceCode> uiSourceCodeList() [event] UISourceCodeListChanged(removed, added) addScript(script) } As a bonus, resources-based mapping and compiler mapping could be cleanly separated. As an another bonus, we can easily implement identical mapping that could be used for a "sanity" debugging mode. Identical mapping doesn't bind scripts to resources and displays VM scripts "as is".
Attachments
Path. (50.30 KB, text/plain)
2012-02-21 11:11 PST, Pavel Podivilov
no flags
Pavel Podivilov
Comment 1 2012-02-21 11:11:48 PST
Created attachment 128002 [details] Path. This patch moves RawSourceCode towards SourceMapping interface defined in previous comment.
Note You need to log in before you can comment on or make changes to this bug.