Bug 79031 – [EFL] Make a pair between evas_object_image_data_set/get.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[JungJik Lee]

Following the guide of EFL(http://docs.enlightenment.org/auto/evas/group__Evas__Object__Image.html),
we should make a pair between evas_object_image_data_get and set.
Because when calling evas_object_image_data_get, the function increases the reference count.
If the ref count is not null, the pixel data is kept inside evas object.
So to return pixel resource, evas_object_image_data_set should be called.

[JungJik Lee]

Created attachment 128445 [details]
proposal patch

[KwangHyuk]

> Source/WebKit/efl/ChangeLog:8
> +        - We get the pixel data when we create the cairo surface.

We ?

> Source/WebKit/efl/ChangeLog:10
> +        We should make a pair between evas_object_image_data_set/get to return evas resource.

I suggest you to specify the reason of evas_object_image_data_set too.
So, it can be a complete sentence.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:52
> +    uint8_t* pixels = static_cast<uint8_t*>(evas_object_image_data_get(tile->image, EINA_TRUE));

EINA_TRUE should be replaced.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:76
> +    cairo_identity_matrix(cairo.get());

I don't think that cairo_identity_matrix() would be required. would you double check ?

[KwangHyuk]

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:71
> +    cairo_scale(cairo.get(), tile->zoom, tile->zoom);

In addition to my previous idea, this doesn't look necessary.

[JungJik Lee]

(In reply to comment #2)
> > Source/WebKit/efl/ChangeLog:8
> > +        - We get the pixel data when we create the cairo surface.
> 
> We ?
> 
I've changed the word.
> > Source/WebKit/efl/ChangeLog:10
> > +        We should make a pair between evas_object_image_data_set/get to return evas resource.
> 
> I suggest you to specify the reason of evas_object_image_data_set too.
> So, it can be a complete sentence.
> 
I append more description.
> > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:52
> > +    uint8_t* pixels = static_cast<uint8_t*>(evas_object_image_data_get(tile->image, EINA_TRUE));
> 
> EINA_TRUE should be replaced.
Done.
> 
> > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:76
> > +    cairo_identity_matrix(cairo.get());
> 
> I don't think that cairo_identity_matrix() would be required. would you double check ?
It's removed.

[JungJik Lee]

Created attachment 128740 [details]
revised patch 1

[KwangHyuk]

LGTM.

[Zoltan Herczeg]

Comment on attachment 128740 [details]
revised patch 1

LGTM

[WebKit Review Bot]

Comment on attachment 128740 [details]
revised patch 1

Clearing flags on attachment: 128740

Committed r108991: <http://trac.webkit.org/changeset/108991>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.