Bug 79018

Summary: perf-o-matic: Extract logic to generate JSON responses as classes to unit test
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Severity: Normal CC: abarth, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 78989    
Bug Blocks: 77037    
Description Flags
refactoring abarth: review+

Description Ryosuke Niwa 2012-02-20 01:21:25 PST
JSON responses for dashboard, manifest, and runs are generated by handler classes at the moment. This prevents us from unit-testing the code to generate JSON responses since handlers can't be unit-tested. We should extract classes out of these handlers in order to unit-test them.
Comment 1 Ryosuke Niwa 2012-02-20 22:54:35 PST
Created attachment 127923 [details]
Comment 2 Ryosuke Niwa 2012-02-21 11:47:36 PST
Comment on attachment 127923 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=127923&action=review

> Websites/webkit-perf.appspot.com/controller.py:52
> +        cache_dashboard(ManifestJSONGenerator().to_json())

Oh oops, this needs to be manifest :(
Comment 3 Adam Barth 2012-02-21 12:32:33 PST
Comment on attachment 127923 [details]

Comment 4 Ryosuke Niwa 2012-02-21 14:26:51 PST
Committed in r108399.