Summary: | AXRoleDescription for HTML5 header element is incorrect | ||
---|---|---|---|
Product: | WebKit | Reporter: | Steve Faulkner <faulkner.steve> |
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | dmazzoni, faulkner.steve, jcraig, mkwst |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Steve Faulkner
2012-02-19 02:06:19 PST
(In reply to comment #0) > Currently the HTML5 header element has an AXRoleDescription="banner". This is the same description as for the ARIA banner landmark role. The current behavior for the `header` element is slightly more complex: if the `header` element is not contained within an `article` or `section` element, it has a description of "banner". If it is contained in one of those elements, it falls back to "group". Regardless of what we do with this bug, we should test that behavior. Same goes for the `footer` element. I'll throw a patch up under https://bugs.webkit.org/show_bug.cgi?id=88911 > Suggest changing to AXRoleDescription="header" "header" or "heading"? The latter would be trivial, the former wouldn't be much more work. Dominic, what do you think about this? (In reply to comment #1) > (In reply to comment #0) > > Currently the HTML5 header element has an AXRoleDescription="banner". This is the same description as for the ARIA banner landmark role. > > The current behavior for the `header` element is slightly more complex: if the `header` element is not contained within an `article` or `section` element, it has a description of "banner". If it is contained in one of those elements, it falls back to "group". > > Regardless of what we do with this bug, we should test that behavior. Same goes for the `footer` element. I'll throw a patch up under https://bugs.webkit.org/show_bug.cgi?id=88911 > > > Suggest changing to AXRoleDescription="header" > > "header" or "heading"? The latter would be trivial, the former wouldn't be much more work. > > Dominic, what do you think about this? Hi Mike, > The current behavior for the `header` element is slightly more complex: if >the `header` element is not contained within an `article` or `section` >element, it has a description of "banner". If it is contained in one of >those elements, it falls back to "group". If this is the case then I think its fine as is. (In reply to comment #1) > (In reply to comment #0) > > Currently the HTML5 header element has an AXRoleDescription="banner". This is the same description as for the ARIA banner landmark role. > > The current behavior for the `header` element is slightly more complex: if the `header` element is not contained within an `article` or `section` element, it has a description of "banner". If it is contained in one of those elements, it falls back to "group". > > Regardless of what we do with this bug, we should test that behavior. Same goes for the `footer` element. I'll throw a patch up under https://bugs.webkit.org/show_bug.cgi?id=88911 > > > Suggest changing to AXRoleDescription="header" > > "header" or "heading"? The latter would be trivial, the former wouldn't be much more work. > > Dominic, what do you think about this? tested with this https://dl.dropbox.com/u/377471/tests/header-role.html works as you described header not in artcile or section = banner header in article/section = group (In reply to comment #3) > tested with this https://dl.dropbox.com/u/377471/tests/header-role.html > > works as you described > header not in artcile or section = banner > header in article/section = group Cool. If you're happy with that behavior, I'll close this bug. I've uploaded some tests to https://bugs.webkit.org/show_bug.cgi?id=88911 to ensure that this behavior doesn't change accidentally in the future. (In reply to comment #4) > (In reply to comment #3) > > tested with this https://dl.dropbox.com/u/377471/tests/header-role.html > > > > works as you described > > header not in artcile or section = banner > > header in article/section = group > > Cool. If you're happy with that behavior, I'll close this bug. I've uploaded some tests to https://bugs.webkit.org/show_bug.cgi?id=88911 to ensure that this behavior doesn't change accidentally in the future. I'm cool with it, also tested footer works the same, nice one! Related to bug 109013. |