Bug 78988

Summary:

Web Inspector: [Styles] box-shadow and -webkit-box-shadow properties are not considered color-aware

Product:

WebKit

Reporter:

Charlie C. <charliemtk>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, paulirish, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://www.tunelinks.com

Attachments:

Description	Flags
Patch	yurys: review+

Charlie C.

Reported 2012-02-18 20:21:06 PST

When using the inspector and changing the settings to use HSL colors, all hex values are converted except for BOX-SHADOW. I'm expecting it to do all. Thanks! Charlie

Attachments
Patch (1.97 KB, patch) 2012-02-20 02:38 PST, Alexander Pavlov (apavlov)	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2012-02-18 23:27:47 PST

Looks like WebInspector.CSSKeywordCompletions._colorAwareProperties in Source/WebCore/inspector/front-end/CSSKeywordCompletions.js has text-shadow but doesn't have box-shadow. We probably just need to add box-shadow to that list.

Alexander Pavlov (apavlov)

Comment 2 2012-02-20 02:38:27 PST

Created attachment 127788 [details] Patch

Alexander Pavlov (apavlov)

Comment 3 2012-02-20 02:51:11 PST

Committed r108229: <http://trac.webkit.org/changeset/108229>

Note You need to log in before you can comment on or make changes to this bug.