Bug 78974

Summary: Make WebCore compile with libc++
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Part 1
none
Part 2 andersca: review+

Sam Weinig
Reported 2012-02-18 13:38:55 PST
Make WebCore compile with libc++
Attachments
Part 1 (1.68 KB, patch)
2012-02-18 13:41 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Part 2 (1.32 KB, patch)
2012-02-18 17:03 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-02-18 13:41:03 PST
Created attachment 127714 [details] Part 1
Sam Weinig
Comment 2 2012-02-18 13:42:14 PST
When libc++ is updated to have we will have to predicate this fix on the libc++ version number.
Sam Weinig
Comment 3 2012-02-18 13:51:20 PST
Part 2 will be to disable DisallowCType.h if using libc++, at least until we can figure out how to make that work. We could be more conservative, since files affected are ones that include wtf/Complex.h.
Sam Weinig
Comment 4 2012-02-18 15:44:57 PST
Committed r108174: <http://trac.webkit.org/changeset/108174>
Sam Weinig
Comment 5 2012-02-18 16:50:15 PST
(In reply to comment #3) > Part 2 will be to disable DisallowCType.h if using libc++, at least until we can figure out how to make that work. We could be more conservative, since files affected are ones that include wtf/Complex.h. One way we could be more conservative about this is to include <wtf/Complex.h> in the prefix header or config.h before we include DisallowCType.h. This has the down side of including wtf/Complex.h everywhere, which transitively includes quite a bit.
Sam Weinig
Comment 6 2012-02-18 17:03:56 PST
Created attachment 127722 [details] Part 2
Sam Weinig
Comment 7 2012-02-18 17:08:49 PST
Committed r108179: <http://trac.webkit.org/changeset/108179>
Note You need to log in before you can comment on or make changes to this bug.