Bug 78967

Summary: AXDescription for HTML5 footer and ARIA role contentinfo incorrect
Product: WebKit Reporter: Steve Faulkner <faulkner.steve>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aaronlevbugs, abarth, bdakin, cfleizach, dglazkov, faulkner.steve, fishd, gustavo.noronha, gustavo, rakuco, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch to change content -> content information
bdakin: review+
patch to add role description for footer elements
webkit-ews: commit-queue-
patch to add separate footer role description
webkit.review.bot: commit-queue-
patch for footer role
gustavo.noronha: commit-queue-
patch for footer role bdakin: review+

Description Steve Faulkner 2012-02-18 10:52:43 PST
Currently the AXRoleDescription string for AXSubRole= AXLandmarkContentInfo is "content". This is ambiguous and does not convey the meaning of the role. Suggest changing the AXRoleDescription to "content information".
The same is used for the HTML5 footer element. In this case it is recommended that the AXRoleDescription be changed to "footer" to disambiguate it from The ARIA landmark contentinfo role as it is not the same.
References:
HTML5 4.4.9 The footer element http://dev.w3.org/html5/spec/the-footer-element.html#the-footer-element
WAI - ARIA 1.0 5. The Roles Model http://www.w3.org/TR/wai-aria/roles#contentinfo
HTML to Platform Accessibility APIs Implementation Guide http://dvcs.w3.org/hg/html-api-map/raw-file/tip/Overview.html
Using WAI ARIA Landmark Roles - http://www.paciellogroup.com/blog/2010/10/using-wai-aria-landmark-roles/
Comment 1 chris fleizach 2012-02-20 08:27:59 PST
Created attachment 127820 [details]
patch to change content -> content information
Comment 2 chris fleizach 2012-02-20 20:48:56 PST
Created attachment 127908 [details]
patch to add role description for footer elements
Comment 3 chris fleizach 2012-02-20 20:50:02 PST
Comment on attachment 127908 [details]
patch to add role description for footer elements

View in context: https://bugs.webkit.org/attachment.cgi?id=127908&action=review

> Source/WebCore/English.lproj/Localizable.strings:567
>  

this was part of the previous patch, got caught up in this patch
Comment 4 Early Warning System Bot 2012-02-20 21:45:59 PST
Comment on attachment 127908 [details]
patch to add role description for footer elements

Attachment 127908 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11558022
Comment 5 chris fleizach 2012-02-27 17:47:25 PST
Created attachment 129151 [details]
patch to add separate footer role description
Comment 6 WebKit Review Bot 2012-02-27 20:51:51 PST
Comment on attachment 129151 [details]
patch to add separate footer role description

Attachment 129151 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11639460
Comment 7 chris fleizach 2012-02-27 23:07:12 PST
Created attachment 129194 [details]
patch for footer role
Comment 8 WebKit Review Bot 2012-02-27 23:10:33 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 9 Collabora GTK+ EWS bot 2012-02-28 06:54:50 PST
Comment on attachment 129194 [details]
patch for footer role

Attachment 129194 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11662158
Comment 10 Darin Fisher (:fishd, Google) 2012-02-28 11:13:38 PST
Comment on attachment 129194 [details]
patch for footer role

Chromium WebKit API changes LGTM
Comment 11 chris fleizach 2012-03-05 17:58:10 PST
Created attachment 130253 [details]
patch for footer role
Comment 12 chris fleizach 2012-03-14 23:02:03 PDT
content -> content info 
http://trac.webkit.org/changeset/110825
Comment 13 chris fleizach 2012-03-14 23:32:50 PDT
footer role->
http://trac.webkit.org/changeset/110828