Bug 78906

Summary: Convert some fast/regions pixel tests to reftests
Product: WebKit Reporter: Rebecca Hauck <rhauck>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, krit, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for the bug
webkit.review.bot: commit-queue-
fixed cr-linux failure none

Rebecca Hauck
Reported 2012-02-17 09:09:35 PST
Convert some fast/regions pixel tests to reftests
Attachments
Patch for the bug (67.34 KB, patch)
2012-02-21 13:56 PST, Rebecca Hauck 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
fixed cr-linux failure (68.67 KB, patch)
2012-02-23 14:54 PST, Rebecca Hauck 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rebecca Hauck
Comment 1 2012-02-21 13:56:25 PST
Created attachment 128038 [details] Patch for the bug Running new-run-webkit-tests --lint-test-files, I'm getting this: LayoutTests/platform/mac/test_expectations.txt:9 fast/dom/shadow/content-element-api.html is also in a Skipped file. LayoutTests/platform/mac/test_expectations.txt:10 fast/dom/shadow/content-element-outside-shadow.html is also in a Skipped file. Lint failed. This does not seem to be related to my patch as I did not touch those files.
WebKit Review Bot
Comment 2 2012-02-21 17:29:32 PST
Comment on attachment 128038 [details] Patch for the bug Attachment 128038 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11562299 New failing tests: fast/regions/float-pushed-width-change.html
Rebecca Hauck
Comment 3 2012-02-23 14:54:45 PST
Created attachment 128563 [details] fixed cr-linux failure new patch - fixed the test failure on cr-linux
Hajime Morrita
Comment 4 2012-02-24 02:35:15 PST
Comment on attachment 128563 [details] fixed cr-linux failure An ideal example of reftests!
WebKit Review Bot
Comment 5 2012-02-24 03:25:00 PST
Comment on attachment 128563 [details] fixed cr-linux failure Clearing flags on attachment: 128563 Committed r108766: <http://trac.webkit.org/changeset/108766>
WebKit Review Bot
Comment 6 2012-02-24 03:25:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.