Bug 78890

Summary: HTML: Remove unnecessary attributeChanged() overrides.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patchy patch
webkit.review.bot: commit-queue-
Patch andersca: review+

Description Andreas Kling 2012-02-17 03:38:29 PST
We should try to make attributeChanged() non-virtual. Let's start by removing some unnecessary overrides.
Comment 1 Andreas Kling 2012-02-17 03:39:55 PST
Created attachment 127569 [details]
Patchy patch
Comment 2 WebKit Review Bot 2012-02-17 10:16:22 PST
Comment on attachment 127569 [details]
Patchy patch

Attachment 127569 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11538543

New failing tests:
media/track/track-default-attribute.html
media/track/track-mode-not-changed-by-new-track.html
http/tests/inspector/inspect-element.html
media/track/track-cues-cuechange.html
http/tests/security/text-track-crossorigin.html
media/track/track-text-track-cue-list.html
media/track/track-webvtt-tc000-empty.html
fast/loader/subresource-willSendRequest-null.html
media/track/text-track-cue-is-reachable.html
media/track/track-cue-mutable.html
media/track/track-add-remove-cue.html
media/track/track-webvtt-tc001-utf8.html
media/track/text-track-is-reachable.html
accessibility/aria-describedby-on-input.html
media/track/track-cues-seeking.html
media/track/track-language-preference.html
media/track/track-cues-enter-exit.html
media/track/track-mode-triggers-loading.html
media/track/track-load-from-element-readyState.html
media/track/track-prefer-captions.html
media/track/track-load-error-readyState.html
inspector/protocol/console-agent.html
Comment 3 Andreas Kling 2012-02-18 02:10:25 PST
Created attachment 127702 [details]
Patch
Comment 4 Andreas Kling 2012-02-18 11:59:09 PST
Committed r108165: <http://trac.webkit.org/changeset/108165>