Bug 78877 – [GObject IDL Parser] STRING argument should be HASHREF

• Component: WebKitGTK
• Status: RESOLVED FIXED

[C Anthony]

i am admittedly not adept with perl, but i believe a mistake was made at one point to "correct" some warnings emitted during `generate-bindings.pl`, specifically `CodeGeneratorGObject.pm`.

emitted error:

Unquoted string "attributes" may clash with future reserved word at ../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1065.

------- previous (eg, WebKitGTK+ 1.6.3):

[...]
 1059   $function->signature->extendedAttributes($attribute->signature->extendedAttributes);
 1060 
 1061   my $param = new domSignature();
 1062   $param->name("value");
 1063   $param->type($attribute->signature->type);
 1064   my %attributes = ();
 1065   $param->extendedAttributes(attributes);
[...]

------- trunk:

[...]
 1090   $function->signature->extendedAttributes($attribute->signature->extendedAttributes);
 1091 
 1092   my $param = new domSignature();
 1093   $param->name("value");
 1094   $param->type($attribute->signature->type);
 1095   my %attributes = ();
 1096   $param->extendedAttributes("attributes");
[...]

-------

notice how quotes were added to "attributes"?  IIUC this is now passing `attributes` as a simple string instead of a HASHREF.  i included the first line (1059 and 1060, resp.) to show how it's used elsewhere ... if i add a simple:

print "ATTR: ", $attribute->signature->extendedAttributes;

------- i get:

[...]
ATTR: HASH(0xf74f78)
ATTR: HASH(0xf814e8)
ATTR: HASH(0xf81a88)
[...]

-------

... suggesting the unused my `%attributes = ();` is the intended type.  seems to still build/etc just fine -- no idea what it's affecting, if anything.

RESOLUTION:

pass "attributes" as \%attributes

[C Anthony]

Created attachment 131248 [details]
Change `attributes` to a hashref

extended attributes (eg, CallWith=XX) are otherwise dropped.  this is a dynamic set_* function anyway, so it's not "really" affecting anything, but is incorrect nonetheless.

[C Anthony]

Created attachment 131356 [details]
Patch

[WebKit Review Bot]

Attachment 131356 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[C Anthony]

Created attachment 131363 [details]
Patch

[WebKit Review Bot]

Comment on attachment 131363 [details]
Patch

Clearing flags on attachment: 131363

Committed r110504: <http://trac.webkit.org/changeset/110504>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.