Bug 78866 – webkit-patch is broken on SL with a new, clean checkout, using Python 2.6.1

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dirk Pranke]

On my corp Mac Pro (running SL + Python 2.6.1), if I have a clean checkout (or remove my webkitpy.thirdparty.autoinstalled directory, then "webkit-patch help" fails trying to auto install irclib :(

[Dirk Pranke]

it works fine, however, on Lion with python 2.7.1 .

[Dirk Pranke]

I've confirmed this on two different machines running the same corp image, so I don't think it's just one machine. I will see if maybe it has something to do with this specific version of irc.

The script keels over trying to decompress the zipfile into a temporary directory; for some reason it is creating the top-level directory python-irclib-0.4.8 as a file, not a directory, and then everything goes south.


Traceback (most recent call last):
  File "/src/wk/Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/tool/main.py", line 38, in <module>
    from webkitpy.common.net.irc import ircproxy
  File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/common/net/irc/ircproxy.py", line 31, in <module>
    from webkitpy.common.net.irc.ircbot import IRCBot
  File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py", line 32, in <module>
    from webkitpy.thirdparty.autoinstalled.irc import ircbot
  File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 80, in find_module
    self._install_irc()
  File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 123, in _install_irc
    url_subpath="irclib.py")
  File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/common/system/autoinstall.py", line 445, in install
    raise Exception(message)
Exception: Error auto-installing the irclib.py package to:
 "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/thirdparty/autoinstalled/irc/irclib.py"
 --> Inner message: [Errno 20] Not a directory: '/var/folders/++/++3pXE++6+0++4RjPqRgNE+-RMo/-Tmp-/irclib.py_YZR9KZ/python-irclib-0.4.8/dccsend'

[Eric Seidel (no email)]

I suspect it failed to download the package from Adam's server. :)

[Dirk Pranke]

(In reply to comment #3)
> I suspect it failed to download the package from Adam's server. :)

Nope, package is downloading fine. I actually changed the version to 0.4.6 to try that, and it failed w/ the same error.

[Adam Barth]

Can you try reverting the recent change to the autoinstaller to remove 2.5 compat?

[Adam Barth]

"to remove" => "that removed"

[Dirk Pranke]

(In reply to comment #5)
> Can you try reverting the recent change to the autoinstaller to remove 2.5 compat?

Oh, you mean, can I revert the change where we stopped using our working code and decided to use the broken system version? Yeah, that fixes the problem :).

I've reopened bug 78173.

[Adam Barth]

> > Can you try reverting the recent change to the autoinstaller to remove 2.5 compat?
> 
> Oh, you mean, can I revert the change where we stopped using our working code and decided to use the broken system version? Yeah, that fixes the problem :).

Yes.  :)

[Dirk Pranke]

*** Bug 78931 has been marked as a duplicate of this bug. ***

[Dirk Pranke]

Created attachment 127648 [details]
Patch

[Adam Barth]

Comment on attachment 127648 [details]
Patch

Thanks for updating the comment.

[Eric Seidel (no email)]

What an excellent example of why good "why" comments are important. :)

Thanks Dirk!

[Dirk Pranke]

Committed r108118: <http://trac.webkit.org/changeset/108118>