Summary: | REGRESSION: Selecting a custom style sheet crashes 20/3 nightly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | musti <mustiman> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Blocker | CC: | alice.barraclough, bdakin, c.petersen87, ggaren | ||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
musti
2006-03-20 21:42:54 PST
I ran into this issue starting with the March 21 build (WebKit-SVN-r13404). You can reproduce by simply applying any external stylesheet to Safari (even a empty stylesheet file) when running Webkit WebKit-SVN-r13404. When I have this page open and I change the user style sheet, Safari tries to load the URL http://bugzilla.opendarwin.org/<contents of the style sheet I selected>. When that fails, it starts loading http://bugzilla.opendarwin.org/<contents of the error page from the previous attempt> and when that fails, it repeats. Created attachment 7220 [details]
Patch
Comment on attachment 7220 [details]
Patch
Better just rename one of the functions.
Comment on attachment 7220 [details]
Patch
It would be even better to rename the one that takes a URL to setStyleSheetLocation, but this is good.
Created attachment 7221 [details]
Rename the function that sets the location
Comment on attachment 7221 [details]
Rename the function that sets the location
Great, lets do this.
Sorry about this. I noticed it last night, but didn't get a fix ready in time. :( I actually had made the exact same fix locally. |