Bug 78835 – Fix use of long long in FractionalLayoutUnit::setRawValue

• Component: Platform
• Status: RESOLVED FIXED

[Emil A Eklund]

setRawValue(long long) which is called by the multiple operator has an assertion to verify that the resulting value is within the range of an int. This currently uses abs(long long) which isn't implemented on all platforms we support.

[Emil A Eklund]

Created attachment 127434 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 127434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127434&action=review

The rest looks fine.

> Source/WebCore/platform/FractionalLayoutUnit.h:122
> +        return value < static_cast<unsigned>(std::numeric_limits<int>::max()) / kFixedPointDenominator;

Why is this necessary?

[Levi Weintraub]

Comment on attachment 127434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127434&action=review

>> Source/WebCore/platform/FractionalLayoutUnit.h:122
>> +        return value < static_cast<unsigned>(std::numeric_limits<int>::max()) / kFixedPointDenominator;
> 
> Why is this necessary?

Since value here is unsigned, you'll get a type warning when comparing them if you don't cast the int.

[Eric Seidel (no email)]

Comment on attachment 127434 [details]
Patch

OK.

[WebKit Review Bot]

Comment on attachment 127434 [details]
Patch

Clearing flags on attachment: 127434

Committed r108006: <http://trac.webkit.org/changeset/108006>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.