Bug 78809

Summary: [Qt][WK2] Allow opaque tiles
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
webkit.review.bot: commit-queue-
Patch none

Description Noam Rosenthal 2012-02-16 06:33:55 PST 
For memory management on different platforms, we want to distinguish between opaque and non-opaque tiles. This would allow us to use 16-bit tiles for opaque layers in platforms that support that.
Comment 1 Noam Rosenthal 2012-02-16 06:40:28 PST 
Created attachment 127369 [details]
Patch
Comment 2 Noam Rosenthal 2012-02-16 07:47:08 PST 
Created attachment 127378 [details]
Patch
Comment 3 WebKit Review Bot 2012-02-16 08:53:49 PST 
Comment on attachment 127378 [details]
Patch

Clearing flags on attachment: 127378

Committed r107943: <http://trac.webkit.org/changeset/107943>
Comment 4 WebKit Review Bot 2012-02-16 08:53:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Noam Rosenthal 2012-02-17 00:01:03 PST 
More patch(es) to come.
Comment 6 Noam Rosenthal 2012-02-17 02:22:37 PST 
Created attachment 127558 [details]
Patch
Comment 7 WebKit Review Bot 2012-02-17 02:26:07 PST 
Comment on attachment 127558 [details]
Patch

Rejecting attachment 127558 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/Shared/ShareableBitmap.h
patching file Source/WebKit2/Shared/qt/ShareableBitmapQt.cpp
patching file Source/WebKit2/UIProcess/qt/LayerBackingStore.cpp
Hunk #1 FAILED at 48.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/qt/LayerBackingStore.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11540426
Comment 8 Noam Rosenthal 2012-02-17 13:06:41 PST 
Created attachment 127639 [details]
Patch
Comment 9 WebKit Review Bot 2012-02-17 15:28:33 PST 
Comment on attachment 127639 [details]
Patch

Clearing flags on attachment: 127639

Committed r108135: <http://trac.webkit.org/changeset/108135>
Comment 10 WebKit Review Bot 2012-02-17 15:28:38 PST 
All reviewed patches have been landed.  Closing bug.