Bug 78796

Summary: [Refactoring] Remove location from NodeRenderingContext.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, morrita, rolandsteiner, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test
none
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-02-16 03:15:02 PST
We had location and phase in NodeRenderingContext because we had to traverse a shadow tree twice to attach it. Currently we don't traverse it twice, we should be able to make NodeRenderingContext much simpler.
Attachments
Test (4.54 KB, patch)
2012-02-16 04:08 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (9.63 KB, patch)
2012-02-16 17:17 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (10.02 KB, patch)
2012-02-16 17:49 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-02-16 04:08:40 PST
Created attachment 127354 [details] Test
Shinya Kawanaka
Comment 2 2012-02-16 17:17:04 PST
Created attachment 127477 [details] Patch
Hajime Morrita
Comment 3 2012-02-16 17:29:14 PST
Comment on attachment 127477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127477&action=review basically looks good. Let's take small time to make the intention clear. > Source/WebCore/dom/NodeRenderingContext.h:79 > }; It's time to give good name for these phase. Could you pick some relevant word from the Shadow DOM node composition algorithm?
Shinya Kawanaka
Comment 4 2012-02-16 17:49:27 PST
Created attachment 127485 [details] Patch
WebKit Review Bot
Comment 5 2012-02-16 20:14:05 PST
Comment on attachment 127485 [details] Patch Clearing flags on attachment: 127485 Committed r108021: <http://trac.webkit.org/changeset/108021>
WebKit Review Bot
Comment 6 2012-02-16 20:14:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.