Summary: | [Refactoring] Remove location from NodeRenderingContext. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> | ||||||||
Component: | DOM | Assignee: | Shinya Kawanaka <shinyak> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, dominicc, hayato, morrita, rolandsteiner, shinyak, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Shinya Kawanaka
2012-02-16 03:15:02 PST
Created attachment 127354 [details]
Test
Created attachment 127477 [details]
Patch
Comment on attachment 127477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127477&action=review basically looks good. Let's take small time to make the intention clear. > Source/WebCore/dom/NodeRenderingContext.h:79 > }; It's time to give good name for these phase. Could you pick some relevant word from the Shadow DOM node composition algorithm? Created attachment 127485 [details]
Patch
Comment on attachment 127485 [details] Patch Clearing flags on attachment: 127485 Committed r108021: <http://trac.webkit.org/changeset/108021> All reviewed patches have been landed. Closing bug. |