Bug 78796

Summary: [Refactoring] Remove location from NodeRenderingContext.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: HTML DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, morrita, rolandsteiner, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test
none
Patch
none
Patch none

Description Shinya Kawanaka 2012-02-16 03:15:02 PST
We had location and phase in NodeRenderingContext because we had to traverse a shadow tree twice to attach it.
Currently we don't traverse it twice, we should be able to make NodeRenderingContext much simpler.
Comment 1 Shinya Kawanaka 2012-02-16 04:08:40 PST
Created attachment 127354 [details]
Test
Comment 2 Shinya Kawanaka 2012-02-16 17:17:04 PST
Created attachment 127477 [details]
Patch
Comment 3 Hajime Morrita 2012-02-16 17:29:14 PST
Comment on attachment 127477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127477&action=review

basically looks good. Let's take small time to make the intention clear.

> Source/WebCore/dom/NodeRenderingContext.h:79
>      };

It's time to give good name for these phase.
Could you pick some relevant word from the Shadow DOM node composition algorithm?
Comment 4 Shinya Kawanaka 2012-02-16 17:49:27 PST
Created attachment 127485 [details]
Patch
Comment 5 WebKit Review Bot 2012-02-16 20:14:05 PST
Comment on attachment 127485 [details]
Patch

Clearing flags on attachment: 127485

Committed r108021: <http://trac.webkit.org/changeset/108021>
Comment 6 WebKit Review Bot 2012-02-16 20:14:11 PST
All reviewed patches have been landed.  Closing bug.