Bug 78796

Summary: [Refactoring] Remove location from NodeRenderingContext.
Product: WebKit Reporter: Shinya Kawanaka <shinyak@chromium.org>
Component: HTML DOMAssignee: Shinya Kawanaka <shinyak@chromium.org>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov@chromium.org, dominicc@chromium.org, hayato@chromium.org, morrita@google.com, rolandsteiner@chromium.org, shinyak@chromium.org, webkit.review.bot@gmail.com
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test
none
Patch
none
Patch none

Description From 2012-02-16 03:15:02 PST
We had location and phase in NodeRenderingContext because we had to traverse a shadow tree twice to attach it.
Currently we don't traverse it twice, we should be able to make NodeRenderingContext much simpler.
------- Comment #1 From 2012-02-16 04:08:40 PST -------
Created an attachment (id=127354) [details]
Test
------- Comment #2 From 2012-02-16 17:17:04 PST -------
Created an attachment (id=127477) [details]
Patch
------- Comment #3 From 2012-02-16 17:29:14 PST -------
(From update of attachment 127477 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=127477&action=review

basically looks good. Let's take small time to make the intention clear.

> Source/WebCore/dom/NodeRenderingContext.h:79
>      };

It's time to give good name for these phase.
Could you pick some relevant word from the Shadow DOM node composition algorithm?
------- Comment #4 From 2012-02-16 17:49:27 PST -------
Created an attachment (id=127485) [details]
Patch
------- Comment #5 From 2012-02-16 20:14:05 PST -------
(From update of attachment 127485 [details])
Clearing flags on attachment: 127485

Committed r108021: <http://trac.webkit.org/changeset/108021>
------- Comment #6 From 2012-02-16 20:14:11 PST -------
All reviewed patches have been landed.  Closing bug.