Bug 78786 – [CSS Regions] Move regions tests from fast/repaint into fast/regions

• Component: CSS
• Status: RESOLVED FIXED

[Mihnea Ovidenie]

There are 4 regions tests in fast/repaint. I intend to move them into fast/regions along with the other css regions tests.

[Mihai Balan]

They are better suited for the fast/repaint folder.

[Mihnea Ovidenie]

At this moment, there are more than 4 repaint tests for regions. Therefore i created a repaint folder under fast/regions and moved all the regions repaint tests there.

[Mihnea Ovidenie]

Created attachment 219414 [details]
Patch

[WebKit Commit Bot]

Attachment 219414 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt', u'LayoutTests/fast/regions/element-in-named-flow-absolute-from-fixed.html', u'LayoutTests/fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt', u'LayoutTests/fast/regions/element-in-named-flow-fixed-from-absolute.html', u'LayoutTests/fast/regions/element-inflow-fixed-from-outflow-static-expected.txt', u'LayoutTests/fast/regions/element-inflow-fixed-from-outflow-static.html', u'LayoutTests/fast/regions/element-outflow-static-from-inflow-fixed-expected.txt', u'LayoutTests/fast/regions/element-outflow-static-from-inflow-fixed.html', u'LayoutTests/fast/regions/fixed-in-named-flow-scroll-expected.txt', u'LayoutTests/fast/regions/fixed-in-named-flow-scroll.html', u'LayoutTests/fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt', u'LayoutTests/fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html', u'LayoutTests/fast/regions/repaint/element-in-named-flow-fixed-from-absolute-expected.txt', u'LayoutTests/fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html', u'LayoutTests/fast/regions/repaint/element-inflow-fixed-from-outflow-static-expected.txt', u'LayoutTests/fast/regions/repaint/element-inflow-fixed-from-outflow-static.html', u'LayoutTests/fast/regions/repaint/element-outflow-static-from-inflow-fixed-expected.txt', u'LayoutTests/fast/regions/repaint/element-outflow-static-from-inflow-fixed.html', u'LayoutTests/fast/regions/repaint/fixed-in-named-flow-scroll-expected.txt', u'LayoutTests/fast/regions/repaint/fixed-in-named-flow-scroll.html', u'LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt', u'LayoutTests/fast/regions/repaint/increasing-region-content-height.html', u'LayoutTests/fast/regions/repaint/japanese-rl-selection-repaint-in-regions.html', u'LayoutTests/fast/regions/repaint/line-flow-with-floats-in-regions.html', u'LayoutTests/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions.html', u'LayoutTests/fast/regions/repaint/region-painting-composited-element-expected.html', u'LayoutTests/fast/regions/repaint/region-painting-composited-element.html', u'LayoutTests/fast/regions/repaint/region-painting-in-composited-view-expected.html', u'LayoutTests/fast/regions/repaint/region-painting-in-composited-view.html', u'LayoutTests/fast/regions/repaint/region-painting-invalidation.html', u'LayoutTests/fast/regions/repaint/region-painting-via-layout.html', u'LayoutTests/fast/regions/repaint/repaint-regions-overflow-expected.txt', u'LayoutTests/fast/regions/repaint/repaint-regions-overflow.html', u'LayoutTests/fast/repaint/increasing-region-content-height-expected.txt', u'LayoutTests/fast/repaint/increasing-region-content-height.html', u'LayoutTests/fast/repaint/japanese-rl-selection-repaint-in-regions.html', u'LayoutTests/fast/repaint/line-flow-with-floats-in-regions.html', u'LayoutTests/fast/repaint/overflow-flipped-writing-mode-block-in-regions.html', u'LayoutTests/fast/repaint/region-painting-composited-element-expected.html', u'LayoutTests/fast/repaint/region-painting-composited-element.html', u'LayoutTests/fast/repaint/region-painting-in-composited-view-expected.html', u'LayoutTests/fast/repaint/region-painting-in-composited-view.html', u'LayoutTests/fast/repaint/region-painting-invalidation.html', u'LayoutTests/fast/repaint/region-painting-via-layout.html', u'LayoutTests/fast/repaint/repaint-regions-overflow-expected.txt', u'LayoutTests/fast/repaint/repaint-regions-overflow.html', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt', u'LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/mac/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/regions/repaint/region-painting-invalidation-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/region-painting-invalidation-expected.txt', u'LayoutTests/platform/mac/fast/regions/repaint/region-painting-via-layout-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/region-painting-via-layout-expected.txt', u'LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png', u'LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png', u'LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png', u'LayoutTests/platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/repaint/region-painting-invalidation-expected.png', u'LayoutTests/platform/mac/fast/repaint/region-painting-invalidation-expected.txt', u'LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.png', u'LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt', u'LayoutTests/platform/win/TestExpectations', u'LayoutTests/platform/wincairo/TestExpectations', '--commit-queue']" exit_code: 1
Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=None)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file
    lines = self._read_lines(file_path)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines
    contents = file.read()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read
    return self.reader.read(size)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read
    newchars, decodedbytes = self.decode(data, self.errors)
UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dirk Schulze]

Comment on attachment 219414 [details]
Patch

rs=me

[Mihnea Ovidenie]

Created attachment 219421 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 219421 [details]
Patch for landing

Clearing flags on attachment: 219421

Committed r160708: <http://trac.webkit.org/changeset/160708>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.