Summary: | MediaStream API: enhance the implementaion of MediaStreamTrack::setEnabled | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | William Lin <wei.a.lin> | ||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, tommyw, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
William Lin
2012-02-15 19:27:02 PST
Created attachment 127299 [details]
Patch
add a patch for review
@tommyw: Thoughts on this patch? Ideally we would test this change as well. Tommy is working on a test framework for this code, which might be helpful. @lin: Please mark your patches "review?" when you'd like them reviewed. That makes the show up in all the appropriate queues. Thanks for the patch. The patch looks like a reasonable thing to do. And fyi, I'll be sending out two more patches for the test framework later today. Comment on attachment 127299 [details]
Patch
I'm tempted to say we should hold off on this patch until the testing framework lands, but I don't want to hold your change hostage. Hopefully we'll get Tommy the necessary reviews for the testing framework shortly and we'll have it ready for your future patches.
The commit-queue encountered the following flaky tests while processing attachment 127299 [details]: storage/indexeddb/index-basics.html bug 79138 (authors: dgrogan@chromium.org and jsbell@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 127299 [details] Patch Clearing flags on attachment: 127299 Committed r108383: <http://trac.webkit.org/changeset/108383> All reviewed patches have been landed. Closing bug. |