Bug 78773 – MediaStream API: enhance the implementaion of MediaStreamTrack::setEnabled

• Component: WebKit API
• Status: RESOLVED FIXED

[William Lin]

in current implementaion of MediaStreamTrack::setEnabled, 
whether or no the MediaStream is live, the track enable/disable setting operation will be called via didSetMediaStreamTrackEnabled().
Actually, if MediaStream is finished, above operation can be ignored.
please notice, the status of MediaStreamTrack can be set regardless of MediaStream' status.

[William Lin]

Created attachment 127299 [details]
Patch

add a patch for review

[Adam Barth]

@tommyw: Thoughts on this patch?

Ideally we would test this change as well.  Tommy is working on a test framework for this code, which might be helpful.

@lin: Please mark your patches "review?" when you'd like them reviewed.  That makes the show up in all the appropriate queues.  Thanks for the patch.

[Tommy Widenflycht]

The patch looks like a reasonable thing to do.

And fyi, I'll be sending out two more patches for the test framework later today.

[Adam Barth]

Comment on attachment 127299 [details]
Patch

I'm tempted to say we should hold off on this patch until the testing framework lands, but I don't want to hold your change hostage.  Hopefully we'll get Tommy the necessary reviews for the testing framework shortly and we'll have it ready for your future patches.

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 127299 [details]:

storage/indexeddb/index-basics.html bug 79138 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 127299 [details]
Patch

Clearing flags on attachment: 127299

Committed r108383: <http://trac.webkit.org/changeset/108383>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.