Bug 78735 – Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)

• Component: WebKit2
• Status: RESOLVED FIXED

[Brian Burg]

Steps to reproduce:

1. Add #define LOG_DISABLED 0 near the top of wtf/Assertions.h (this is behavior that should be supported; see the top of Assertions.h)
2. Compile on Mac for Release build
3. Build will fail when linking WebKit2


Causes:

In WebKit2/Platform/mac/Logging.mac.mm:

* the implementation of WebKit::initializeLogChannel should be guarded by #if !LOG_DISABLED, but is actually guarded by #ifndef NDEBUG. This will cause build breakage if LOG_DISABLED is manually set to false in wtf/Assertions.h, but WebKit is compiled in release mode.

In WebCore/Exports/ExportFileGenerator.cpp and WebCore.exp.in:

* the export of symbol __ZN7WebCore20LogNotYetImplementedE is similarly improperly guarded by #if !defined(NDEBUG), whereas it should be guarded by #if !LOG_DISABLED


(I don't have a working copy, so can't produce a usable patch right now. But this is a 5 minute fix.)

[Andres Gomez Garcia]

Created attachment 217686 [details]
Failing build log in Mac when setting the GCC_PREPROCESSOR_DEFINITION "LOG_DISABLED" to 0

(In reply to comment #0)
> Steps to reproduce:
> 
> 1. Add #define LOG_DISABLED 0 near the top of wtf/Assertions.h (this is behavior that should be supported; see the top of Assertions.h)
...

This is not needed, it can be achieved with:
$ Tools/Scripts/build-webkit GCC_PREPROCESSOR_DEFINITIONS='${inherited} LOG_DISABLED=0'

...
> Causes:
> 
> In WebKit2/Platform/mac/Logging.mac.mm:
> 
> * the implementation of WebKit::initializeLogChannel should be guarded by #if !LOG_DISABLED, but is actually guarded by #ifndef NDEBUG. This will cause build breakage if LOG_DISABLED is manually set to false in wtf/Assertions.h, but WebKit is compiled in release mode.
> 
> In WebCore/Exports/ExportFileGenerator.cpp and WebCore.exp.in:
> 
> * the export of symbol __ZN7WebCore20LogNotYetImplementedE is similarly improperly guarded by #if !defined(NDEBUG), whereas it should be guarded by #if !LOG_DISABLED
...

This is not true anymore since this guards where changing some time ago.

However, compiling with LOG_DISABLED=0 is not workind due to missing dependencies as shown in the attached log file.

[Andres Gomez Garcia]

Created attachment 217687 [details]
Patch

[Mario Sanchez Prada]

Comment on attachment 217687 [details]
Patch

Looks ok to me

[WebKit Commit Bot]

Comment on attachment 217687 [details]
Patch

Clearing flags on attachment: 217687

Committed r159695: <http://trac.webkit.org/changeset/159695>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.