Bug 78722 – Expose Window constructor

• Component: DOM
• Status: RESOLVED CONFIGURATION CHANGED

[Erik Arvidsson]

We currently do not expose the Window constructor. Other browsers do.

assertTrue(window.Window !== undefined)

This is related to bug 78721 which is about renaming the constructor.

[Ian 'Hixie' Hickson]

Constructor? You mean prototype object, right? Window shouldn't be a constructor.

[Erik Arvidsson]

(In reply to comment #1)
> Constructor? You mean prototype object, right? Window shouldn't be a constructor.

No. I mean constructor. It is not constructable but it is still a constructor. Just like Document and HTMLDocument are exposed.

IE and Mozilla pass the following

assertTrue(typeof Window !== 'undefined');

[Erik Arvidsson]

Created attachment 127211 [details]
Patch

[WebKit Review Bot]

Comment on attachment 127211 [details]
Patch

Clearing flags on attachment: 127211

Committed r107869: <http://trac.webkit.org/changeset/107869>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Reopen, because it broke 3 tests on Qt. I assume that on other platforms too, but unfortunately I can't check it, because build.webkit.org is unavailable.
- fast/dom/Window/window-properties.html - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107900%20%2833816%29/fast/dom/Window/window-properties-pretty-diff.html
- fast/dom/Window/window-property-descriptors.html - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107900%20(33816)/fast/dom/Window/window-property-descriptors-pretty-diff.html
- fast/js/global-constructors.html - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107900%20%2833816%29/fast/js/global-constructors-pretty-diff.html

I think the first two tests only needs to be rebaselined. But the third one seems an error: +FAIL Window.toString() should be [object WindowConstructor]. Was [object DOMWindowConstructor].

[Csaba Osztrogonác]

I updated the 3 tests on Qt - http://trac.webkit.org/changeset/107916
Please check what should we do with the 3rd failing test.

[Erik Arvidsson]

Sorry about that. These tests where in the test_expectation.txt for chromium. I should have realized it would change the expectations for JSC based platforms.

(In reply to comment #7)
> I updated the 3 tests on Qt - http://trac.webkit.org/changeset/107916
> Please check what should we do with the 3rd failing test.

The FAIL in global-constructors-expected.txt is bug 78721

The changes to the Skipped file seems unrelated though.

[Ahmad Saleem]

From WPT - Safari passes all "window constructor" events, do we need anything further?

https://wpt.fyi/results/dom/events?label=master&label=experimental&aligned&q=constructor

Please ignore my comment, if I incorrect or wrong and update latest status accordingly. Thanks!

[Ryosuke Niwa]

We have window.Window now.

[Radar WebKit Bug Importer]

<rdar://problem/97612310>