Summary: | [GTK] Document that local paths in html loaded with loadHTML might cause the web process to terminate | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, pnormand, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-02-15 08:31:11 PST
Created attachment 127188 [details]
Patch
I hope it's clear enough
Attachment 127188 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9
Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging Source/WebCore/ChangeLog
Auto-merging Source/WebCore/platform/graphics/GraphicsContext3D.h
CONFLICT (content): Merge conflict in Source/WebCore/platform/graphics/GraphicsContext3D.h
Auto-merging Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp
CONFLICT (content): Merge conflict in Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp
Auto-merging Source/WebKit/qt/ChangeLog
CONFLICT (content): Merge conflict in Source/WebKit/qt/ChangeLog
Auto-merging Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp
CONFLICT (content): Merge conflict in Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp
Failed to merge in the changes.
Patch failed at 0001 [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".
rebase refs/remotes/origin/master: command returned error: 1
Died at Tools/Scripts/update-webkit line 164.
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 127188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127188&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:890 > + * must be in the same directory than @base_uri. Asbolute local paths pointing to a > + * different directory than @base_uri will cause the web process to terminate. > + * If you need to include URLs in @content that are local paths in a different > + * directory than @base_uri you can build a data uri for them. When @base_uri is %NULL, Would a phrase like "Absolute local paths must be children of the @base_uri" be clearer? You might mention that this is for security reasons specifically. Asbolute -> Absolute :) Committed r107904: <http://trac.webkit.org/changeset/107904> |