Summary: | Avoid full style recalc when 'style' attribute changes. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | DOM | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | anilsson, dglazkov, efidler, eric, gmak, jamesr, koivisto, macpherson, mlattanzio, morrita, staikos, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2012-02-15 08:17:00 PST
Created attachment 127187 [details]
Patch
Attachment 127187 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9
Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging Source/WebCore/ChangeLog
Auto-merging Source/WebCore/platform/graphics/GraphicsContext3D.h
CONFLICT (content): Merge conflict in Source/WebCore/platform/graphics/GraphicsContext3D.h
Auto-merging Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp
CONFLICT (content): Merge conflict in Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp
Auto-merging Source/WebKit/qt/ChangeLog
CONFLICT (content): Merge conflict in Source/WebKit/qt/ChangeLog
Auto-merging Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp
CONFLICT (content): Merge conflict in Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp
Failed to merge in the changes.
Patch failed at 0001 [Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".
rebase refs/remotes/origin/master: command returned error: 1
Died at Tools/Scripts/update-webkit line 164.
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 127187 [details] Patch Attachment 127187 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11518875 New failing tests: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html The patch looks OK, but it looks like some other part of the code is depending on this style resolution. We'll need to debug that layout test failure. (In reply to comment #4) > The patch looks OK, but it looks like some other part of the code is depending on this style resolution. We'll need to debug that layout test failure. Yep, looks like setAttribute('style', '-webkit-appearance: none') works for this today, but .style.webkitAppearance = 'none' does not. Crazy. CC'ing morrita who added the test. Created attachment 174821 [details]
Patch
Let's try this again, as I can't reproduce the failure anymore. I suspect that something got fixed in shadow DOM styling over the last 9 months and this now works as it should.. *fingers crossed for ews*
Comment on attachment 174821 [details] Patch Clearing flags on attachment: 174821 Committed r135051: <http://trac.webkit.org/changeset/135051> All reviewed patches have been landed. Closing bug. |