Bug 78677

Summary:

[Qt][WK2] Clipping is broken

Product:

WebKit

Reporter:

Noam Rosenthal <noam>

Component:

Layout and Rendering

Assignee:

Noam Rosenthal <noam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, jturcotte, kenneth, ostap73, webkit.review.bot, yael

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	webkit.review.bot: commit-queue-
Patch	none
Patch to fix regression	none
Patch	hausmann: review+
Patch	none

Noam Rosenthal

Reported 2012-02-15 01:05:50 PST

We don't apply the scene clipping for QtSceneGraph correctly, so the web-page appears to render in the wrong places, like behind the address bar.

Attachments
Patch (4.71 KB, patch) 2012-02-20 09:58 PST, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch for landing (4.75 KB, patch) 2012-02-20 15:25 PST, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch for landing (4.75 KB, patch) 2012-02-20 15:35 PST, Noam Rosenthal	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (4.54 KB, patch) 2012-02-20 15:46 PST, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch to fix regression (2.92 KB, patch) 2012-02-21 12:08 PST, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch (20.21 KB, patch) 2012-02-22 17:30 PST, Noam Rosenthal	hausmann: review+	Details Formatted Diff Diff
Patch (19.75 KB, patch) 2012-02-23 06:14 PST, Noam Rosenthal	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Noam Rosenthal

Comment 1 2012-02-20 09:58:16 PST

Created attachment 127829 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2012-02-20 12:58:54 PST

Comment on attachment 127829 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127829&action=review Great that you fixed the issue! > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:835 > + for (int i = data().sharedGLData().clipStack.size() - 1; i >=0; --i) { style... missing space. Also why do you need to intersect them using reverse order?

Noam Rosenthal

Comment 3 2012-02-20 15:25:11 PST

Created attachment 127856 [details] Patch for landing

WebKit Review Bot

Comment 4 2012-02-20 15:27:34 PST

Comment on attachment 127856 [details] Patch for landing Rejecting attachment 127856 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11550288

Noam Rosenthal

Comment 5 2012-02-20 15:35:03 PST

Created attachment 127861 [details] Patch for landing

WebKit Review Bot

Comment 6 2012-02-20 15:37:33 PST

Comment on attachment 127861 [details] Patch for landing Rejecting attachment 127861 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11552265

Noam Rosenthal

Comment 7 2012-02-20 15:46:14 PST

Created attachment 127863 [details] Patch

WebKit Review Bot

Comment 8 2012-02-20 17:20:06 PST

Comment on attachment 127863 [details] Patch Clearing flags on attachment: 127863 Committed r108274: <http://trac.webkit.org/changeset/108274>

WebKit Review Bot

Comment 9 2012-02-20 17:20:11 PST

All reviewed patches have been landed. Closing bug.

Noam Rosenthal

Comment 10 2012-02-21 09:36:05 PST

Reopening, this caused an assert at the end of painting if there's any layer-clipping in the page.

Noam Rosenthal

Comment 11 2012-02-21 09:37:45 PST

process 4345 is executing new program: /home/abecsi/devel/git/webkit-git-svn/WebKitBuild/Debug/bin/QtWebProcess ASSERTION FAILED: !data().sharedGLData().clipStack.isEmpty() ../../../../Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp(857) : bool WebCore::TextureMapperGL::endScissorClip() 1 0x7ffff561e6f8 /home/abecsi/devel/git/webkit-git-svn/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN7WebCore15TextureMapperGL14endScissorClipEv+0x78) [0x7ffff561e6f8] 2 0x7ffff561ee0b /home/abecsi/devel/git/webkit-git-svn/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN7WebCore15TextureMapperGL7endClipEv+0x1b) [0x7ffff561ee0b] 3 0x7ffff4694663 /home/abecsi/devel/git/webkit-git-svn/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN6WebKit18LayerTreeHostProxy23paintToCurrentGLContextERKN7WebCore20TransformationMatrixEfRKNS1_9FloatRectE+0x2cf) [0x7ffff4694663] 4 0x7ffff45e7bbe /home/abecsi/devel/git/webkit-git-svn/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN6WebKit20DrawingAreaProxyImpl23paintToCurrentGLContextERKN7WebCore20TransformationMatrixEfRKNS1_9FloatRectE+0x5c) [0x7ffff45e7bbe] 5 0x7ffff45d2ed9 /home/abecsi/devel/git/webkit-git-svn/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN20QQuickWebPagePrivate23paintToCurrentGLContextEv+0x187) [0x7ffff45d2ed9] 6 0x7ffff45d32a2 /home/abecsi/devel/git/webkit-git-

Noam Rosenthal

Comment 12 2012-02-21 12:08:33 PST

Created attachment 128017 [details] Patch to fix regression

Noam Rosenthal

Comment 13 2012-02-22 17:30:47 PST

Created attachment 128346 [details] Patch

Kenneth Rohde Christiansen

Comment 14 2012-02-23 02:30:25 PST

Comment on attachment 128346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128346&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:205 > + void initStencil(); initialize? > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:348 > + if (data().sharedGLData().currentClipState.scissorBox.isEmpty()) does the current add any value to the name? clipState would be current, so I think it is a bit obvious, but maybe i am missing something > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:766 > + // Increase stencilIndex and apply stencil testing testing. testing testing?

Simon Hausmann

Comment 15 2012-02-23 04:10:00 PST

Comment on attachment 128346 [details] Patch LGTM modulo Kenneth's suggestions (testing testing is tested :)

Noam Rosenthal

Comment 16 2012-02-23 06:14:14 PST

Created attachment 128471 [details] Patch

WebKit Review Bot

Comment 17 2012-02-23 16:24:21 PST

Comment on attachment 128471 [details] Patch Clearing flags on attachment: 128471 Committed r108696: <http://trac.webkit.org/changeset/108696>

WebKit Review Bot

Comment 18 2012-02-23 16:24:26 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.